Spinning "loading" icon remains after CloudFile upload fails
Categories
(Thunderbird :: FileLink, defect)
Tracking
(thunderbird_esr91? fixed)
People
(Reporter: darktrojan, Assigned: TbSync)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-esr91+
|
Details | Review |
STR:
Compose a new message
Add an attachment
Ask to upload it to WeTransfer (fails due to bug 1705109)
Close the error message prompt
Attachment icon is still the spinning icon
Comment 1•3 years ago
|
||
This is a duplicate of bug 1681188, but this description is better.
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 3•2 years ago
•
|
||
STR without WeTransfer: Just throw an error in the onFileUploaded event listener.
Am I right in assuming the entire attachment should be removed in case upload failed? Or does a failed upload should keep the attached file as a regular file with standard file type icon?
If the add-on is aborting the upload as described in bug 1681188, should Thunderbird pop a message (which it does when throwing an error in the onFileUploaded event handler), or should that be left to the add-on?
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 4•2 years ago
|
||
There is two user experience flows:
- User adds a file as a regular attachment, then either clicks "Link" in the yellow bar or chooses "convert to..." from the attachment's context menu.
- User adds a FileLink file directly by choosing "Filelink..." from the "Attach" menu.
For those two cases two different behaviors would make sense from user's perspective:
In case 1) the file was a regular attachment, upload failed, so the file is still a regular attachment.
In case 2) there was no regular attachment before user action. If the upload fails there should not be a regular attachment afterwards.
The rationale for this is: In both cases the status is the same as it was before the user interaction that failed.
Assignee | ||
Comment 5•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4c8097ff5e30
Remove spinner and the attachment after upload failed. r=mkmelin
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 8•2 years ago
|
||
Comment on attachment 9252539 [details]
Bug 1715405 - Remove spinner and the attachment after upload failed. r=mkmelin
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Missing out the improved icon handling of cloud files.
Testing completed (on c-c, etc.):
Baked on 96 for 2 weeks.
Risk to taking this patch (and alternatives if risky):
Low.
Comment 9•2 years ago
|
||
Comment on attachment 9252539 [details]
Bug 1715405 - Remove spinner and the attachment after upload failed. r=mkmelin
[Triage Comment]
Approved for esr91
Comment 10•2 years ago
|
||
bugherder uplift |
Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/0d3cb77c04ef
Description
•