Closed Bug 1715424 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29202 - URLPattern: Support optional protocol ':', search '?', and hash '#'.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 29202 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29202
Details from upstream follow.

b'Ben Kelly <wanderview@chromium.org>' wrote:

URLPattern: Support optional protocol ':', search '?', and hash '#'.

This allows us to support passing a URL object directly to test() or
exec(). For example:

let p = new URLPattern({ pathname: '/foo' });
let u = new URL('https://example.com/foo');
p.test(u); // true

This would previously always return false because the URL.protocol
getter returns https: and URLPattern was expecting https.

Bug: 1141510
Change-Id: I26c27633a9201e604a895df44c215f7d0a8ef753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919344
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Commit-Queue: Ben Kelly \<wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890549}

Attached file Notable wpt changes
# CI Results Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 4 tests and 226 subtests ## Status Summary ### Firefox OK : 4 PASS : 4 FAIL : 900 ### Chrome OK : 4 PASS : 896 FAIL : 8 ### Safari OK : 3 PASS : 3 FAIL : 675 ERROR: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=e04e5bf9ccba561b0d87ebabf0bb7ab06b4d4406) [GitHub PR Head](https://wpt.fyi/results/?sha=f90392334421b0874eaeed5b84d91889f472e71a&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=f90392334421b0874eaeed5b84d91889f472e71a&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e5d9ea778fbc [wpt PR 29202] - URLPattern: Support optional protocol ':', search '?', and hash '#'., a=testonly https://hg.mozilla.org/integration/autoland/rev/c3a7581aca99 [wpt PR 29202] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: