1715477 - [Wayland] Content menu is opened on wrong position when bookmark menu is shown

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Content menu is opened on wrong position when bookmark menu is shown. It's because we don't recalculate popup hierarchy after popup close.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1715477 [Wayland] Update popup hierarchy when we close popup, r?jhorak

• Split WaylandPopupHierarchyUpdateByLayout() to WaylandPopupHierarchyHideByLayout() and WaylandPopupHierarchyMarkByLayout().
  When a popup is closed we need to mark ective popups again which is done by WaylandPopupHierarchyMarkByLayout().

• Allow move-to-rect poupup positioning only when it matches layout and is anchored or it's the first popup attached to toplevel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac08d8af9935
[Wayland] Update popup hierarchy when we close popup, r=jhorak

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1710436

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ac08d8af9935

Comment 5

[Martin Stránský [:stransky] (ni? me)]

This is a minor regression from bug 1710436, we may consider to uplift to beta.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
If yes, don't forget to request an uplift for the patches in the regression caused by this fix.

For more information, please visit auto_nag documentation.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Let's keep it at 91 as it introduces some other regressions.

Comment 8

[Oana Botisan, Desktop QA]

Can you please provide more specific steps to reproduce this issue, because I was not able to do so. I tried to reproduce the issue using Nightly from 2021-06-06 on macOS 10.15.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to Oana Botisan, Desktop Release QA from comment #8)

Can you please provide more specific steps to reproduce this issue, because I was not able to do so. I tried to reproduce the issue using Nightly from 2021-06-06 on macOS 10.15.

This is Linux / Wayland issue. Can be reproduced in Wayland environment, for instance on Fedora 33/34 / Gnome or Ubuntu 21.04 / Gnome.