Closed
Bug 1715484
Opened 3 years ago
Closed 3 years ago
Stop syncing browser.urlbar.resultBuckets
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: mak, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We may end up syncing an old definition onto a new one, maybe the new value contains just added buckets, like inputhistory and when we sync up an old version over it we lose the new bucket. It looks like a footgun and maybe it's already causing bugs.
We should stop syncing, and likely also change the pref name to avoid old versions syncing over it.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 91.1 - May 31 - Jun 13
Points: --- → 2
Priority: P2 → P1
|
|
Assignee | |
Comment 1•3 years ago
|
||
I renamed the pref to resultBucketSet. This is similar enough that we don't have to change a lot of code. Functions and comments that refer to resultBuckets now clearly refer to resultBucketSet. As Marco pointed out in the bug, the renaming is necessary to avoid conflicts with old versions.
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c98845429ae7 Stop syncing browser.urlbar.resultBuckets and rename the pref. r=adw
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•