1715569 - environment.settings.sandbox.contentWin32kLockdownState missing from telemetry environment schema

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[William Lachance (:wlach)]

In bug 1709383, a new variable called contentWin32kLockdownState was added to the telemetry environment but the schema was not updated, so we're not currently ingesting this into BigQuery.

https://github.com/mozilla-services/mozilla-pipeline-schemas/commit/6b1c1d448abc517d186634c33271678341e25547#diff-b4cfab9a42f90abfc0115cb77945e965563eb6d4cc3f4eabbaf02c0cec48f40d is a good example of adding this. The only file you actually need to change is templates/include/telemetry/environment.1.schema.json -- then just rebuild the schemas per the instructions in the repository's README

Comment 1

[Chris Martin [:cmartin]]

I do currently have an GitHub Issue raised to add this: https://github.com/mozilla-services/mozilla-pipeline-schemas/issues/679

I tried to do it myself, but TBH I had a bunch of issues with the instructions as-written on Ubuntu, talked to Chutten, and he mentioned that this is not normally done by mere mortals such as myself but generally by the folks that own the project.

Comment 2

[William Lachance (:wlach)]

In the past we've done this on behalf of others but we'd prefer to get out of this habit.

The cmake build instructions should work (IIRC only cmake, jq, and python are really required). If you have issues running them, could you ping us in the #telemetry channel on Matrix?

Comment 3

[Chris Martin [:cmartin]]

Hi William,

I tried to add the new value to the schema -- The cmake step worked just fine, but then I went to try to test with Docker by using this ./scripts/mps-build, and it did not work. Here is a log of the failure:

CentOS Linux 8 - AppStream                       10 MB/s | 7.4 MB     00:00    
CentOS Linux 8 - BaseOS                         4.3 MB/s | 2.6 MB     00:00    
Dependencies resolved.
================================================================================
 Package               Architecture    Version            Repository       Size
================================================================================
Installing:
 epel-release          noarch          8-8.el8            extras           23 k

Transaction Summary
================================================================================
Install  1 Package

Total download size: 23 k
Installed size: 32 k
Downloading Packages:
epel-release-8-8.el8.noarch.rpm                  46 kB/s |  23 kB     00:00    
--------------------------------------------------------------------------------
Total                                            30 kB/s |  23 kB     00:00     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                        1/1 
  Installing       : epel-release-8-8.el8.noarch                            1/1 
  Running scriptlet: epel-release-8-8.el8.noarch                            1/1 
  Verifying        : epel-release-8-8.el8.noarch                            1/1 

Installed:
  epel-release-8-8.el8.noarch                                                   

Complete!
Extra Packages for Enterprise Linux Modular 8 - 817 kB/s | 611 kB     00:00    
Extra Packages for Enterprise Linux 8 - x86_64  9.1 MB/s | 9.5 MB     00:01    
No match for argument: cmake3
Package diffutils-3.6-6.el8.x86_64 is already installed.
Package which-2.21-12.el8.x86_64 is already installed.
Error: Unable to find a match: cmake3
The command '/bin/sh -c dnf -y update &&     dnf -y install epel-release &&     dnf -y install         cmake3         diffutils         gcc         gcc-c++         jq         make         which         wget         git         python36         java-1.8.0-openjdk-devel         maven         cargo     && dnf clean all' returned a non-zero code: 1

Comment 4

[William Lachance (:wlach)]

(In reply to Chris Martin [:cmartin] from comment #3)

Hi William,

I tried to add the new value to the schema -- The cmake step worked just fine, but then I went to try to test with Docker by using this ./scripts/mps-build, and it did not work. Here is a log of the failure:

I would skip the mps-build step-- you can rely on CI to run those. Just commit the results of running cmake and make a pull request. :)

I'll update the docs to make it more clear this step is normally not required.

Comment 5

[Chris Martin [:cmartin]]

Resolved with Github PR 685