1715600 - Calendar week numbers easily confused with day numbers

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[dev]

Attachment: Screenshot 2021-06-09 at 19.26.59.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

1. Choose Multiweek or Month view.
2. See week number in day box in same color as day number (at the right)

Actual results:

Upon glance/quick look, week number (e.g. 26) is easily mistaken for day number (e.g. 28).

Expected results:

1. Choose Multiweek or Month view.
2. See week number not in a day box together with the day number, but in front of the week row. Alternatively, or additionally, see the week number in a different color and/or facetype than the day number so it stands out from the day numbers.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1715600-calendar-week-number.patch

The dark theme doesn't differentiate the week number with lowered luminance.

I also made the week numbers italics.

What do you think about this?

Comment 2

[Thomas D. (:thomas8)]

Attachment: Mockup 1: Use localized week number abbreviation, e.g. W 26 (en) or S 26 (fr)

Perhaps we could use localized one-character abbreviation of the word "week" in front of the week number.

Richard, can you attach a screenshot how it looks with your patch applied?

Italics may be a bit week as a distinction (although it's certainly better).
I also liked W 26 (character + italics).

Comment 3

[Thomas D. (:thomas8)]

Attachment: Mockup 2: localized character + italics

Comment 4

[Richard Marti (:Paenglab)]

Attachment: screenshot with patch applied

Comment 5

[dev]

Great!
A letter ('W') only makes it really explicit.
Italics only: more subltle, works nicely as well.
Not sure what UX experts would prefer (no italics to keep numbers similarly formatted, or sacrificing estate by using a letter, or both), but all these would do the trick I think.

Comment 6

[Thomas D. (:thomas8)]

Attachment: Mockup 3: Round brackets around week number

Trying other ways of distinguishing the week number:
Here's round brackets.

Comment 7

[Alessandro Castellani [:aleca]]

Using localized letter I think it's a good idea.
The format would be First letter of the word "week" [space] number.
No need to make it italic, it looks a bit weird and disconnected from the rest.
The opacity variation introduced by Richard should be enough to visually separate that label from the date number.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1715600-calendar-week-number.patch

I haven't used Fluent to not mix with the properties in the same function. I hope it's okay like this.

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9226319 [details] [diff] [review]
1715600-calendar-week-number.patch

Review of attachment 9226319 [details] [diff] [review]:
-----------------------------------------------------------------

This is good IMHO, but maybe we could use the occasion to move stuff to Fluent.
Pinging Magnus to know what he thinks.
Let's hold on from checking in this until we hear from him.

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9226319 [details] [diff] [review]
1715600-calendar-week-number.patch

Review of attachment 9226319 [details] [diff] [review]:
-----------------------------------------------------------------

Of course the underlying problem here is that for some reason we don't have a separate column for week number, like more or less every other calendar out there has...
Maybe we should just make sure to fix that instead? It's a rather major annoyance.

I think the patch is not quite correct. If we go this route, basically, abbreviationOfWeek in en-US is wrong, and should get the W addition. Manually plussing two localized strings together is not appropriate either. But, looks like nobody wanted to localize this anyway: https://searchfox.org/l10n/search?q=abbreviationOfWeek&path=&case=false&regexp=false

Comment 11

[Richard Marti (:Paenglab)]

Attachment: 1715600-calendar-week-number.patch

Now I see how this abbreviationOfWeek works. I think because the original abbreviationOfWeek had no "W" no other locale added it.

Fixing it by adding the "W". You're okay with the multiweekViewWeek?

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9226774 [details] [diff] [review]
1715600-calendar-week-number.patch

Review of attachment 9226774 [details] [diff] [review]:
-----------------------------------------------------------------

It's an improvement. Still think it should be a separate column, but we can leave that for another bug.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/64bbd687d6d1
Differentiate the week number also with the dark theme. r=aleca

Comment 14

[Thomas D. (:thomas8)]

Nice incremental improvement, thanks everyone!