Closed Bug 1715602 Opened 5 years ago Closed 2 years ago

Crash in [@ mozilla::dom::ContentParent::CreateBrowser]

Categories

(Core :: DOM: Content Processes, defect, P3)

Product:
Core
Component:
DOM: Content Processes
Platform:
Unspecified
All
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- fix-optional

People

(Reporter: kbrosnan, Unassigned)

Details

(Keywords: crash, regression, Whiteboard: [not-a-fission-bug])

Crash Data

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/6b37d020-7e92-45d2-b1e0-05d6f0210609

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(!aBrowsingContext->Canonical()->GetBrowserParent()) (BrowsingContext must not have BrowserParent, or have previous BrowserParent cleared)

Top 6 frames of crashing thread:

0 libxul.so mozilla::dom::ContentParent::CreateBrowser dom/ipc/ContentParent.cpp:1492
1 libxul.so nsFrameLoader::TryRemoteBrowser dom/base/nsFrameLoader.cpp:2731
2 libxul.so nsFrameLoader::GetBrowsingContext dom/base/nsFrameLoader.cpp:3437
3 libxul.so mozilla::dom::FrameLoader_Binding::get_browsingContext dom/bindings/FrameLoaderBinding.cpp:344
4  @0x7a573333d4 
5  @0x7a573333d4
Severity: -- → S2

Nika added this MOZ_DIAGNOSTIC_ASSERT recently in bug 1699721:

https://searchfox.org/mozilla-central/rev/bea2345ce636dc329ac7133fc0a13c9171777e40/dom/ipc/ContentParent.cpp#1462-1465

Looks like Windows and macOS are affected in addition to Android. There were 10 reports from Nightly 90, but none from Nightly 91 so far.

Fission Milestone: --- → ?
status-firefox89: --- → affected
status-firefox90: --- → affected
status-firefox91: --- → ?
status-firefox-esr78: --- → affected
OS: Android → All
Regressed by: 1699721
Summary: Crash in [@ mozilla::dom::ContentParent::CreateBrowser] → MOZ_DIAGNOSTIC_ASSERT(!aBrowsingContext->Canonical()->Get BrowserParent())Crash in [@ mozilla::dom::ContentParent::CreateBrowser]
Has Regression Range: --- → yes

This crash can affect non-Fission. Here's a Windows crash report:

https://crash-stats.mozilla.org/report/index/ad896ff0-b04e-4848-aea0-c9aa70210529

Fission Milestone: ? → ---
Flags: needinfo?(nika)
Priority: -- → P2
Summary: MOZ_DIAGNOSTIC_ASSERT(!aBrowsingContext->Canonical()->Get BrowserParent())Crash in [@ mozilla::dom::ContentParent::CreateBrowser] → MOZ_DIAGNOSTIC_ASSERT(!aBrowsingContext->Canonical()->Get BrowserParent()) Crash in [@ mozilla::dom::ContentParent::CreateBrowser]

Fenix 91.0a1 is affected, but I still don't see any reports from desktop 91.0a1.

status-firefox91: ? → affected
Whiteboard: [not-a-fission-bug]

The MOZ_DIAGNOSTIC_ASSERT(!aBrowsingContext->Canonical()->Get BrowserParent()) appeared last time during the 96 beta cycle. There are sparse crashes in that function in release, but they seem to be unrelated.

Severity: S2 → S3
Flags: needinfo?(nika)
Priority: P2 → P3
Summary: MOZ_DIAGNOSTIC_ASSERT(!aBrowsingContext->Canonical()->Get BrowserParent()) Crash in [@ mozilla::dom::ContentParent::CreateBrowser] → Crash in [@ mozilla::dom::ContentParent::CreateBrowser]
Keywords: regression
No longer regressed by: 1699721

Closing because no crashes reported for 12 weeks.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.