1715650 - Linter to catch new COM initialization calls in Windows builds

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[(No longer employed by Mozilla) Aaron Klotz]

As of bug 1707954 landing, I would like us to begin failing Windows builds when a patch adds new calls to the following functions:

• CoInitialize
• CoInitializeEx
• CoUninitialize
• OleUninitialize
• OleInitialize
• RoInitialize
• RoUninitialize

We will need a list of exceptions, as there are many extant calls already in the tree. Furthermore, mozilla::mscom::ProcessRuntime and mozilla::mscom::EnsureMTA should be exempt, as these two classes are the ones that actually do need to make such calls.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1715650: Add linter for detecting COM initialization; r=#linter-reviewers

This patch adds a new linter that will error when new code mentions any one of
the following strings:

• CoInitialize;
• CoInitializeEx;
• OleInitialize;
• RoInitialize;
• CoUninitialize;
• OleUninitialize; and
• RoUninitialize.

Since I don't care about context, and just want to flag code containing these
names, I opted for a regex linter.

Yes, the regex does match a few strings beyond the above list (in particular, it
also matches additional strings that end with an Ex suffix), but since
functions with those names don't exist anyway (and would be errors in their own
right), I am not concerned about it.

All existing occurrences have been added to the exclusion list, with the
intent of removing most of them over time.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5633cc2e32cfd8734b0d124888934af9807e073

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61489e2d0094
Add linter for detecting COM initialization; r=linter-reviewers,andi

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/61489e2d0094