Closed Bug 1715667 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29320 - Update cached attribute values before updating children

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox91 fixed)

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29320 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29320
Details from upstream follow.

b'Aaron Leventhal <aleventhal@google.com>' wrote:

Update cached attribute values before updating children

When updating children of a node, first update it's cached attribute
values. This prevents a situation where
UpdateCachedAttributeValuesIfNeeded() would be called on the same
node and potentially mark try to this->SetNeedToUpdateChildren() while
|this| is already in the middle of updating children.

Bug: 1208404

Change-Id: I087afb61502b629104b430b0990b504a96276a1e

Reviewed-on: https://chromium-review.googlesource.com/2939686
WPT-Export-Revision: 0fc38662324b698c731815ba7720d41616695b27

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e89ce09af55c
[wpt PR 29320] - Update cached attribute values before updating children, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e89ce09af55c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.