171567 - crash if FreshDownload plugin started

Status: VERIFIED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Brant Gurganus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20020928
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20020928

If the FreshDownload plugin gets initiated, it will crash.  This causes Mozilla
to crash.

Reproducible: Always

Steps to Reproduce:
1. Install the latest version of FreshDownload and enable plugin.
2. Attempt to download a supported file type.
Actual Results:  
FreshDownload plugin crashes.  This causes Mozilla to crash.

Expected Results:  
Neither should crash.  Since you have no control of the FreshDownload plugin,
Mozilla should not crash when the FreshDownload plugin crashes.

Fresh Devices has been contacted.  I have received no reply.

Comment 1

[Oliver Klee]

Brant, could you post the Talkback ID of the crash? Thank you!

Comment 2

[Brant Gurganus]

Since I have been recently upgrading builds, many are not known to me, but can
be queried for [e-mail] as email and FreshDownload
in comments.

The only one I currently have is:
TB11753410X

Comment 3

[rubydoo123]

The FreshDownload app does not register within the About Plug-ins. Executing
fd.exe opens FreshDownload as an independent application and I can access a file
and download correctly.

Brant: can you give me a step by step description as to how the app is supposed
to work within the mozilla app?

tested on winXP using a trunk build from today.

Comment 4

[rubydoo123]

I forgot to mention that I did not find an np*.dll file for the FreshDownload app

Comment 5

[greer]

Attachment: TB Stack

Stack from reporter's TB incident #11753410

Comment 6

[rubydoo123]

Reporter: do you have 4.x installed on your system? Where on your disk is the
npfd.dll located?

Comment 7

[Brant Gurganus]

FreshDownload 4.6
Mozilla 2002092808 (installed by installer)
Windows XP Home SP1

In FreshDownload, go to Options > Integration.
Put a check mark for Integrate with Mozilla.
Click OK.

npfd.dll should now be in your plugin directory.
About:plugins gives:

FreshDownload Plugin

    File name: npfd.dll
    FreshDownload Plugin

MIME Type Description Suffixes Enabled
application/octet-stream exe Yes
application/x-msdownload exe Yes
application/zip zip Yes
application/x-zip-compressed gz Yes
application/rar rar Yes
application/arj arj Yes
audio/wav wav Yes
audio/x-wav wav Yes
audio/mpeg mp3 Yes
video/mpeg mp2 Yes
video/quicktime mpg Yes
video/msvideo mpeg Yes
video/x-msvideo avi Yes
video/x-ms-asf asf Yes

Try downloading a file of one of those types to recreate the crash.

Comment 8

[Brant Gurganus]

If you are referring to NS 4.x, I don't have it.

Comment 9

[rubydoo123]

rant: bless your heart -- thanks for explaining how to integrate the two apps,
I'll test it right now!

Comment 10

[rubydoo123]

Brant: I think I have found the problem, Mozilla has its own download manager.
When I went to Edit|Preferences|Navigator|Downloads and selected to "Don't Open
Anything" - FreshDownload worked just fine. I did, btw, do you what explained to
integrate the two applications. I am using a trunk build from 2002100104 on win2K

Can you try turning the Mozilla download manager off and see if this resolves
your crash?

Comment 11

[Brant Gurganus]

The plugin still isn't working.  What build are you using to test with?  The
plugin worked (with download manager on) with builds closer to the release build
(marking regression for that reason).  Has something with plugin architecture
changed?  Latest Talkback:
TB11884637X

Perhaps any difference between the stack dumps can narrow down whether it is
related to the download manager settings in any way.

Comment 12

[rubydoo123]

I am using a build from today. Asking Andrei if he can narrow it down, since I
cannot reproduce the crash. I am not seeing anything striking in the talkback,
hopefully Andrei does see it.

Comment 13

[av (gone)]

Attachment: some binary file for testing purposes (vmmre32.dll)

Comment 14

[av (gone)]

With my yesterday debug build I don't see the crash either. The plugin seems to
work. It fails to download the previous attachement saying that it cannot
determine the file size but I think this is another issue.

Shrirang, what do you see?

Comment 15

[shrirang khanzode]

I used today's trunk on my NT (1001), installed the app and plugin, tried to 
download an exe and it just worked fine. No crash, no nothing.

Comment 16

[av (gone)]

Marking WFM then.

Comment 17

[Brant Gurganus]

I got around to downloading a new build and it did start working again.  There
must have been some plugin work somewhere I would think.