1715713 - Prevent showing multiple newmailalert.xhtml notification windows

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Ping Chen [:rnons] (away)]

When Use the system notification is turned off, and when receiving several messages in a short time, multiple newmailalert.xhtml may be shown laying on each other. Slightly older notifications are hidden and blocked by newer notifications.

Should add a queue to show the next after the current is closed.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1715713 - Prevent showing multiple newmailalert.xhtml notification windows. r=mkmelin

This patch makes two changes:

1. If a newmailalert.xhtml window is already shown, save the folder and show a new notification only after the current notification is closed.
2. Pass new message keys to newmailalert.js. Previously, newmailalert.js receives a root folder and scans all subfolders for NEW messages, which is unnecessary and may incorrectly include old messages.

Comment 2

[Ping Chen [:rnons] (away)]

This will fix bug 1715735 as well.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/81f4842d2dd7
Prevent showing multiple newmailalert.xhtml notification windows. r=mkmelin

Comment 4

[Ping Chen [:rnons] (away)]

Comment on attachment 9226743 [details]
Bug 1715713 - Prevent showing multiple newmailalert.xhtml notification windows. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 715799
User impact if declined: 1. When not using the system alert, multiple newmailalert.xhtml may block each other. 2. In some cases, old mails are shown in the alert repeatedly
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9226743 [details]
Bug 1715713 - Prevent showing multiple newmailalert.xhtml notification windows. r=mkmelin

[Triage Comment]
Accepted for 90.0b2

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 90.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/eb46687b27fa