1715726 - With `Display Attachments Inline`, attached email message shows no message headers in inline preview

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect, P2)

Description

[Julian Field]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.1 Safari/605.1.15

Steps to reproduce:

Ensure "View -> Display Attachments Inline" is ticked in menus.
Open a message which contains a forwarded-as-attachment message.

Actual results:

The forwarded-as-attachment message body is shown, but now does not even show the Subject: line of it, let alone the From or To headers.

Expected results:

Prior to Thunderbird 90.0b1, it showed the Subject: From: and To: headers immediately above the body of the forwarded-as-attachment message.

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: TB 90.0b1 no longer showing message header in inline preview of attached .eml

Indeed, thanks for reporting this.
Confirming exactly as described for TB 90.0b1, Win10.

Comment 2

[Thomas D. (:thomas8)]

Confirmed also for Daily 91.0a1 (2021-06-28) (64-bit) - Magnus, could you assign this to someone?
Not showing the message header of an attached message in message reader's inline preview is quite a significant loss of context which negatively impacts the usefulness of Display attachments inline for email messages.

Comment 3

[José M. Muñoz]

Alice, can you please find the regression for us. I guess the STR are pretty clear from comment #0. The header display is put together in some MIME code, so it's surprising this would have changed.

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=1d81d0c7d689925122e9febf5bf048bd0edfa4a8&tochange=9b4135fcf96dee01ffe7ee6b6229ff6dc8d69669
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf16dfb1a2297df01a2b9143f2f1fa6bfa29da66&tochange=1bbf4362b266645db009c5895b8dd5a41ebb09a9

Suspect: Bug 1711408

Comment 5

[José M. Muñoz]

Thank you so much, Alice. Indeed, MIME changes that put the message together.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1715726 - Fix display of the headers of attached messages in inline preview. r=mkmelin

Comment 7

[José M. Muñoz]

Nice, inline display of message/rfc822 attachments shows the headers again, but it's impossible to check printing since this either hangs on the preview or crashes completely. Maybe that's bug 1720397 or bug 1714639.

Comment 8

[Geoff Lankow (:darktrojan)]

I checked printing as one of those bugs has a patch to prevent the crash. All is good.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/882bf054ad43
Fix display of the headers of attached messages in inline preview. r=mkmelin

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9231090 [details]
Bug 1715726 - Fix display of the headers of attached messages in inline preview. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1711408 made changes to the message stylesheet that did too much
User impact if declined: message attachments displayed inline have no headers
Testing completed (on c-c, etc.): tested in comment 7
Risk to taking this patch (and alternatives if risky): low, I just changed the stylesheet and added a class to some elements, worst case is it's still broken

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9231090 [details]
Bug 1715726 - Fix display of the headers of attached messages in inline preview. r=mkmelin

[Triage Comment]
Approved for beta

Comment 12

[Calum Mackay]

This still seems to be a problem, for me, in MacOS build Daily 2021-07-17, which seems odd, if it was pushed 3 days ago?

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/1bae09992082

Comment 14

[Calum Mackay]

I'm still not seeing the fix, as of 0719; is it just me?

Comment 15

[Calum Mackay]

thanks Rob.

Comment 16

[Rob Lemley [:rjl]]

Confirming comment 12, that on macOS with Thunderbird 92.0a1 (2019-07-19) the headers are not displayed. It does work on Linux. Opened Bug 1721232 for macOS.