Closed Bug 1715739 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29325 - bind-gen: Enable the new IDL dictionary implementations

Categories

(Core :: DOM: Web Authentication, task, P4)

Product:
Core
Component:
DOM: Web Authentication
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29325 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29325
Details from upstream follow.

b'Yuki Shiino <yukishiino@chromium.org>' wrote:

bind-gen: Enable the new IDL dictionary implementations

Enables the new IDL dictionary implementations.

The APIs are compatible and no major difference, but there are
minor differences between the old and new IDL dictionary
implementations:

  1. Exact distinction between "missing" and IDL null.
    (dict->foo() is invalid when !dict->hasFoo().)
  2. Use the new IDL unions and the new IDL enumerations as
    member types of the IDL dictionaries.
  3. Move support for (Heap)Vector members.

The pinpoint result:
https://pinpoint-dot-chromeperf.appspot.com/job/1484ae38320000

bind-gen: switch

Bug: 839389
Change-Id: I5fddb608d9a43685963410861955bbd63162935b
Reviewed-on: https://chromium-review.googlesource.com/2928684
WPT-Export-Revision: 889ca77df96529c35685f9a1b1feb9efc7b864fd

Component: web-platform-tests → DOM: Web Authentication
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 13 subtests

Status Summary

Firefox

PASS : 11
TIMEOUT: 2

Chrome

OK : 1
PASS : 12
FAIL : 1

Safari

ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webauthn/createcredential-badargs-rp.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: ERROR)
Bad rp: icon is insecure: TIMEOUT (Chrome: PASS)

Tests Disabled in Gecko Infrastructure

/webauthn/createcredential-badargs-rp.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d02b42569d7
[wpt PR 29325] - bind-gen: Enable the new IDL dictionary implementations, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9d02b42569d7

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.