1715748 - Expose both light and dark system theme colors to chrome UI

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

In the longer term, perhaps this should be done with the color-scheme CSS property. But for now exposing the two sets of system colors via a chrome function seems easy enough.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1715748 - Add an internal -moz-system-color() function to expose both light and dark system colors. r=#style,#layout-reviewers

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1715748 - Expose text selection foreground / background colors to chrome code. r=#style,#layout-reviewers

Depends on D117416

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cca441d5cc81
Add an internal -moz-system-color() function to expose both light and dark system colors. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/44d7bcefdc8b
Expose text selection foreground / background colors to chrome code. r=jwatt

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1715748 - Don't use NS_SAME_AS_FOREGROUND_COLOR on android for -moz-nativehyperlinktext color. r=#geckoview-reviewers

This shouldn't have a meaningful behavior change, as the default link
color right now is taken from the browser.anchor_color pref.

Returning this color from -moz-nativehyperlinktext makes no sense, and
it wasn't being handled correctly before: On GeckoView this color was
transparent.

The other patches in this bug cause NS_SAME_AS_FOREGROUND_COLOR to be
handled correctly, as currentColor, and cause a test failure on android
which asserts that -moz-nativehyperlinktext doesn't return the initial
value.

This color is supposed to be internal, but is has been historically
exposed to the web. Will try to unship these on a follow-up bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6ab0521071e
Don't use NS_SAME_AS_FOREGROUND_COLOR on android for -moz-nativehyperlinktext color. r=agi a=orange

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cca441d5cc81
https://hg.mozilla.org/mozilla-central/rev/44d7bcefdc8b
https://hg.mozilla.org/mozilla-central/rev/b6ab0521071e