1715944 - [win7] Changing OS theme with Firefox opened displays a grey bar over browsers controls when changed to Aero theme or black bar near buttons for other themes

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: win7.1-2.gif

Filled on request -> link. I marked this as an S3 because 88.0.1 is affected as well. Also, the issue may be intermittent and disappears after a restart.

Affected versions

• 91.0a1 (20210608215751)
• 90.0b6 (20210610185818)
• 89.0 (20210527174632)
• 88.0.1 (20210504152106)
• 78.11.0esr (20210531140902)

Affected platforms

• Windows 7

Steps to reproduce

1. Open Firefox.
2. Change between Windows 7 themes and observe the tab bar.

Expected result

• Tab bar is displayed as expected.

Actual result

• Close, Minimize and Maximize buttons are covered when changing to the Default theme and glitches may be seen when changing to other themes.

Regression range

• Reproduced with 86.0a1 (20210110213430) as well. I will search for one ASAP.

Notes

• Attached a screen recording.

Comment 1

[Alexandru Trif, Desktop QA [:atrif]]

Hello. Made a regression range on Windows 7x64:
Last good revision: d34716786f5b0159ca32bdfbc86fcb6c747618c8 (2020-04-30)
First bad revision: 0f9c5a59e45d34f53ab4d44058ed016d4bacf942 (2020-05-01)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d34716786f5b0159ca32bdfbc86fcb6c747618c8&tochange=0f9c5a59e45d34f53ab4d44058ed016d4bacf942
I hope this helps because the issue may be intermittent.

Comment 2

[:Gijs (he/him)]

(In reply to Alexandru Trif, QA [:atrif] from comment #1)

Hello. Made a regression range on Windows 7x64:
Last good revision: d34716786f5b0159ca32bdfbc86fcb6c747618c8 (2020-04-30)
First bad revision: 0f9c5a59e45d34f53ab4d44058ed016d4bacf942 (2020-05-01)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d34716786f5b0159ca32bdfbc86fcb6c747618c8&tochange=0f9c5a59e45d34f53ab4d44058ed016d4bacf942
I hope this helps because the issue may be intermittent.

bug 1633718 is in this range and looks potentially related. Toshi, is it possible these theme calls fail in classic mode, and then start working in aero but we don't bother re-running them?

Comment 3

[Toshihito Kikuchi [:toshi]]

(In reply to :Gijs (he/him) from comment #2)

bug 1633718 is in this range and looks potentially related. Toshi, is it possible these theme calls fail in classic mode, and then start working in aero but we don't bother re-running them?

Confirmed the repro. You're perfectly right. In the Classic mode, OpenThemeData returns null, and there is a defect in the fix of bug 1633718 where we never re-fetch a theme handle in that case.

Comment 4

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1715944 - Set the cached theme handle to Nothing() if the holding value was null. r=gijs

In the class stlye of Win7, OpenThemeData returns null. The problem is
ThemeHandle::Close() did not reset the cached value to Nothing() if
the holding value was null. As a result, we never fetch the theme handle
after the theme is changed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeb33cef0825
Set the cached theme handle to Nothing() if the holding value was null.  r=Gijs

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/aeb33cef0825

Comment 7

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: win7_theme.gif

Hello! While verifying this with Firefox 92.0a1 (20210808090543) Windows 7x64 I observed that when changing from Windows7 Aero theme to Windows 7 Basic theme there is a black square on the Minimize, Maximize, and Close buttons. This fixes after a restart. Is this expected, or should we file a new bug for this?
When changing from aero to Classic or High Contrast the buttons are displayed as expected.
Thank you!

Comment 8

[Toshihito Kikuchi [:toshi]]

(In reply to Alexandru Trif, QA [:atrif] from comment #7)

Hello! While verifying this with Firefox 92.0a1 (20210808090543) Windows 7x64 I observed that when changing from Windows7 Aero theme to Windows 7 Basic theme there is a black square on the Minimize, Maximize, and Close buttons. This fixes after a restart. Is this expected, or should we file a new bug for this?

I could not reproduce that issue on my Win7 VM. In my test environment, I didn't even see the "Please Wait" popup when switching from Windows 7 Aero to Windows 7 Basic. Did you change any theme settings from the default?

Comment 9

[Alexandru Trif, Desktop QA [:atrif]]

(In reply to Toshihito Kikuchi [:toshi] from comment #8)

(In reply to Alexandru Trif, QA [:atrif] from comment #7)

Hello! While verifying this with Firefox 92.0a1 (20210808090543) Windows 7x64 I observed that when changing from Windows7 Aero theme to Windows 7 Basic theme there is a black square on the Minimize, Maximize, and Close buttons. This fixes after a restart. Is this expected, or should we file a new bug for this?

I could not reproduce that issue on my Win7 VM. In my test environment, I didn't even see the "Please Wait" popup when switching from Windows 7 Aero to Windows 7 Basic. Did you change any theme settings from the default?

Hello!
I didn't change anything inside themes from what I can remember. Also, we reproduced the issue on two different machines with windows 7 installed and for me, the issue can be seen every time I switch from Windows 7 Aero Theme to Windows 7 Basic.

After further looking into this it seems that sometimes the Please Wait pop-up is not displayed for me either when switching between Windows 7 Aero and Basic themes. I can make it work again when changing to Windows Classic theme, then Windows 7 Aero, and then Windows 7 Basic in this order, and the issue can be seen.