Closed Bug 1715970 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29342 - Always use the referrer used to load the document on same-document navigations

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29342 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29342
Details from upstream follow.

b'Rakina Zata Amni <rakina@chromium.org>' wrote:

Always use the referrer used to load the document on same-document navigations

DidCommitProvisionalLoadParams has the referrer param that is used
to save the referrer attribute in FrameNavigationEntry after commit.

Currently, most same-document navigations will use the initial referrer
that's used to load the document, even after several navigations. An
exception to this is if the navigation is classified as a client-side
redirect, in which case the previous URL is used. This seems to be
accidental, as the referrer_ that's tracked in the DocumentLoader is
never actually updated for these navigations, so future same-document
navigations will still use the initial referrer that's used to load the
document.

This CL removes the special behavior for client-side redirect same-doc
navigations, to make the behavior more predictable, making it easier
to calculate the referrer param in the browser in the future, and also
allows us to remove the redirect chain in the renderer completely in
crrev.com/c/2933038.

Bug: 1171210, 1131832
Change-Id: If460d5fe08ab5795b3dd4d69b0188289d8253839
Reviewed-on: https://chromium-review.googlesource.com/2938762
WPT-Export-Revision: dc62c438b4aec28409eb531f3951a3183476365f

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS : 1

Chrome

OK : 1
PASS : 1

Safari

TIMEOUT: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af1cb445717d
[wpt PR 29342] - Always use the referrer used to load the document on same-document navigations, a=testonly

https://hg.mozilla.org/mozilla-central/rev/af1cb445717d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.