Closed Bug 1715982 Opened 4 months ago Closed 4 months ago

Incorrect initial capacity computation for NumberPartVector

Categories

(Core :: Internationalization, defect, P1)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: anba, Assigned: dminor)

References

(Blocks 1 open bug)

Details

(Whiteboard: [i18n-unification])

Attachments

(1 file)

NumberPartVector:

using NumberPartVector = mozilla::Vector<NumberPart, 8 * sizeof(NumberPart)>;

It's incorrect to multiply by sizeof(NumberPart) here. It should be instead:

using NumberPartVector = mozilla::Vector<NumberPart, 8>;

Thanks for catching this!

Assignee: nobody → dminor
Severity: -- → S3
Priority: -- → P1
Blocks: 1686965
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24439c0e5af4
Fix initial capacity of NumberPartVector; r=anba
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Whiteboard: [i18n-unification]
You need to log in before you can comment on or make changes to this bug.