Closed Bug 1715982 Opened 2 years ago Closed 2 years ago

Incorrect initial capacity computation for NumberPartVector

Categories

(Core :: Internationalization, defect, P1)

Product:
Core
Component:
Internationalization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: anba, Assigned: dminor)

References

Details

(Whiteboard: [i18n-unification])

Attachments

(1 file)

Bug 1715982 - Fix initial capacity of NumberPartVector; r=anba!
48 bytes, text/x-phabricator-request
Details | Review

NumberPartVector:

using NumberPartVector = mozilla::Vector<NumberPart, 8 * sizeof(NumberPart)>;

It's incorrect to multiply by sizeof(NumberPart) here. It should be instead:

using NumberPartVector = mozilla::Vector<NumberPart, 8>;

Thanks for catching this!

Assignee: nobody → dminor
Severity: -- → S3
Priority: -- → P1
Blocks: 1686965
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24439c0e5af4
Fix initial capacity of NumberPartVector; r=anba

https://hg.mozilla.org/mozilla-central/rev/24439c0e5af4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox91: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Whiteboard: [i18n-unification]
You need to log in before you can comment on or make changes to this bug.