1716013 - [wpt-sync] Sync PR 29345 - [composite-bgcolor-animation] Return empty result when PaintWorkletInput not found

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 29345 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29345
Details from upstream follow.

b'Xida Chen <[e-mail]>' wrote:

[composite-bgcolor-animation] Return empty result when PaintWorkletInput not found

The root cause of the problem is that there is an early exit in the
DiscardableImageMap::GatherDiscardableImages(), happening when the
paint rect for the op is empty. This makes sense because there is
nothing to draw.

The |PaintWorkletImageProvider::records_| contains the records for
all the discardable images that can draw. Meaning that the ones that
early exits won't be included in the |records_|. But, when the
PaintWorkletImageProvider::GetPaintRecordResult() is called, the
input parameter |PaintWorkletInput| would contain all possible
PaintWorkletInput that is passed from Blink to CC, which obviously
contains the ones that cannot draw. As a result, these
PaintWorkletInputs won't exists in the |records_|.

We handle these cases by returning an empty record because there
is nothing to draw (like empty container cases).

Bug: 1216210
Change-Id: I9630aa4b55fd1322f641f42b05c20aab8c7234c7

Reviewed-on: https://chromium-review.googlesource.com/2954479
WPT-Export-Revision: ed6d90222dccf0f2fd3dff4a78848fc4ffb4a645

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eafdcb58de2e453d35efa3ef696586b8e5dc31c2

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5311bc0fc13a3b9d4cb346d6d9f64b69e19362ba

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/136c0fe36862
[wpt PR 29345] - [composite-bgcolor-animation] Return empty result when PaintWorkletInput not found, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/136c0fe36862