Closed Bug 1716045 Opened 6 months ago Closed 6 months ago

Optimize moz_bullet_font_family instantiation

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mats, Assigned: emilio)

Details

(Keywords: perf)

Attachments

(3 files)

Flags: needinfo?(emilio)

This changes font-family storage to reuse the rust types, removing a
bunch of code while at it. This allows us to, for example, use a single
static font family for -moz-bullet and clone it, rather than creating a
lot of expensive copies.

Just drive-by, but seems reasonable to avoid the per-element comparison
if the pointers are the same.

Depends on D118015

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a85091ff664f
Implement ArcSlice copy/move-assignment operators. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/85a42db20576
Optimize ArcSlice equality operator for pointer equality. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/fbcaf33d96a4
Unify font-family storage. r=mats,jfkthame
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.