17161 - View|Sidebar checkbox is backwards when default is open

Status: VERIFIED DUPLICATE of bug 17347

(SeaMonkey :: Sidebar, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  I permamently closed my sidebar a while ago by unchecking
View|Sidebar.  However, some (I think a little more than 50%) of the time, when
I start apprunner, the sidebar comes up open.  (However, there's no check mark
on the menu, and toggling the menu keeps the check mark exactly the reverse of
reality.)  I would suspect this is some sort of a timing bug...

STEPS TO REPRODUCE:

 * Select View | Sidebar so the sidebar is closed, and a pref is set so it
stays closed

 * Launch apprunner, possibly many times (it's hard to reproduce)

ACTUAL RESULTS:
 * sometimes, the sidebar comes up open, as described above

EXPECTED RESULTS:
 * sidebar always closed

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-10-24-08-M11

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

OK - I see what's happening now.  There are two problems:

 * the sidebar state pref doesn't work at all anymore (a regression)
 * the View|Sidebar box is initially unchecked, but the sidebar is initially
open.


The reason I thought the pref was working sometimes was that when I closed the
sidebar and opened a new window, the sidebar was closed and everything was in
sync.

Comment 2

[Paul MacQuiddy]

the open/close pref not being persistent is covered under bug 13901. I'm not
sure how the checkmark is supposed to work.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I was talking about the "View | Sidebar" no longer being persistent (it's a
different, but similar, problem).  I think that broke when the sidebar switched
to being an XUL overlay.

Comment 4

[Paul MacQuiddy]

okay, I really meant bug 16516 :-)

Comment 5

[Steve Lamm]

Paul is right this is a duplicate of bug 16516.

The hiding of the sidebar is no longer done with preferences. It uses XUL
persistence. Unfortunately, persistence does not work when the app crashes, or
fails to shutdown properly.

*** This bug has been marked as a duplicate of 16516 ***

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified duplicate.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm reopening this because only half of it was a duplicate.  The bit about the
checkbox being reversed is still not fixed.  *If* your default sidebar state is
open, then the checkbox is always reversed.  (That is, if the window opens
showing a sidebar, then the checkbox is initially unchecked.)

Comment 8

[Steve Lamm]

I have a fix ready.

*** This bug has been marked as a duplicate of 17347 ***

Comment 9

[Joseph Elwell]

[bugday] verifying duplicity (of two parent dupe bugs)