Use harfbuzz instead of sfntly for font subsetting
Categories
(Core :: Graphics: Text, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
Now that harfbuzz has font subsetting support, we should be able to eliminate our use of sfntly and build Skia with harfbuzz subsetting instead. This would let us remove sfntly from the build entirely.
In principle I think this just means building with SK_PDF_USE_HARFBUZZ_SUBSET
instead of SK_PDF_USE_SFNTLY
, but have not yet tried this.
One caveat is that the hb-subset API is not necessarily stable yet (e.g. see https://github.com/harfbuzz/harfbuzz/pull/3021), which means we may need to be a bit careful about coordinating Skia and harfbuzz updates.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
This seems to build OK according to tryserver: https://treeherder.mozilla.org/jobs?repo=try&revision=324e32ed046313d51f775a555c184f8adecc88ff. Functionality is untested; do we actually use SkiaPDF for anything in a standard build at the moment? (I guess I'll try to print via skia-pdf and see what happens...)
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cefe0dbb2aaa Build SkiaPDF with harfbuzz subsetting, and eliminate use of sfntly. r=jrmuizel
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a453bb7f2c36 Fix linting opt black failure. r=lint-fix
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cefe0dbb2aaa
https://hg.mozilla.org/mozilla-central/rev/a453bb7f2c36
Description
•