1716217 - Download manager shows confusing number of downloads string

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[djrasmussen71]

Attachment: Clipboard01.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Downloading several files at the same time.

Actual results:

Download manager said I had only 4 downloads going, when I actually had 9. (The image shows 5, but there were 9 total ongoing. When some finish, the wrong number is still shown.

Expected results:

Download manager should report the correct number of ongoing downloads.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alin Ilea, Desktop QA]

Attachment: 2021-06-18_11h48_57.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Hi,

I have tested your issue on latest FF release 89, Beta 90.0b7 and latest Nightly build 91.0a1 (2021-06-18) and could not reproduce it using Windows 10 because on my end the bottom section which shows the number of downloads is not displayed.
If the issue is still reproducible on your end, can you please retest this using latest Nightly build (https://nightly.mozilla.org/) and report back the results? When doing this, please use a new clean Firefox profile (https://goo.gl/AWo6h8) to eliminate the potential causes.

Thanks for the report.

Comment 3

[djrasmussen71]

Attachment: Nightly A.png

Comment 4

[djrasmussen71]

Attachment: Nightly B.png

Comment 5

[djrasmussen71]

(In reply to Alin Ilea from comment #2)

Created attachment 9227843 [details]
2021-06-18_11h48_57.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Hi,

I have tested your issue on latest FF release 89, Beta 90.0b7 and latest Nightly build 91.0a1 (2021-06-18) and could not reproduce it using Windows 10 because on my end the bottom section which shows the number of downloads is not displayed.
If the issue is still reproducible on your end, can you please retest this using latest Nightly build (https://nightly.mozilla.org/) and report back the results? When doing this, please use a new clean Firefox profile (https://goo.gl/AWo6h8) to eliminate the potential causes.

Thanks for the report.

Able to reproduce 100% of the time on Nightly 91.0a1 (2021-06-18) (64-bit) with a clean profile. I believe the number at the bottom showing the number of downloads only shows up if you have 6 or more downloads going. I have attached images (Nightly A & B) from reproduction on the Nightly build in which it stated I had 3 downloads, but actually had 8. Can you please try to reproduce on your end with 6 or more downloads?

Comment 6

[Alin Ilea, Desktop QA]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Hi,

djrasmussen71 you are right, I am able to reproduce the issue in release 89, beta 90.0b10 and latest nightly 91.0a1 (2021-06-22) using Windows 10.

Thanks for your input.

Comment 7

[Alin Ilea, Desktop QA]

Attachment: downloads issue.png

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think that is the number of downloads not shown in the panel. The panel shows 5 downloads inline, others are grouped into that final button, and the number is the number of downloads that are not visible.

This is indeed a bit confusing and something for UX polish, it should probably say "Other 2 files downloading" or "2 more files downloading"

Comment 9

[Meridel [:meridel]]

Flod, we are putting a copy bandaid on this and updating strings to:

If just one additional file: "1 more file downloading"
If more than one additional file: "2 more files downloading"

Molly noted that this string is in a .properties file, so it would also need a fluent migration, but it doesn't look like a particularly tricky one.

Comment 10

[Francesco Lodolo [:flod]]

Thanks for the heads-up, I don't foresee any specific problem for this string.

Comment 11

[Sam Foster [:sfoster] (he/him)]

:flod, do you know anything about the history of this properties file. Is there a reason it hasn't already been migrated to Fluent?

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #11)

:flod, do you know anything about the history of this properties file. Is there a reason it hasn't already been migrated to Fluent?

AFAIK only lack of resources, I'm not aware of specific technical limitations at this point (e.g. things that Fluent wouldn't be able to deal with).

Comment 13

[djrasmussen71]

Just wanted to say thank you for continuing to look into changing the wording on the download manager.

Comment 14

[kpatenio]

Attachment: Bug 1716217 - Migrate other downloads panel string to Fluent. r=mtigley!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9dd1c8978f3
Migrate other downloads panel string to Fluent. r=fluent-reviewers,flod,Gijs

Comment 16

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a9dd1c8978f3

Comment 17

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue on Windows 10 x64 using an affected nightly build 91.0a1 (2021-06-13) and the STR from comment 0.

Verified as fixed on the latest beta 95.0b8 (20211116185800), acroos the following platforms: Win 10, Ubuntu 20.04 and macOS 10.15.
The strings were updated to: "1 more file downloading" and "x more files downloading" (for more than one additional file).