Open Bug 1716401 Opened 3 years ago Updated 3 years ago

Fix browser/components/resistfingerprinting/test/mochitest/test_hide_gamepad_info.html test skipped in 'browser/components/resistfingerprinting/test/mochitest/mochitest.ini' for fission xorigin

Categories

(Core :: Privacy: Anti-Tracking, task)

task

Tracking

()

Fission Milestone Future
Tracking Status
firefox-esr78 --- disabled
firefox-esr91 --- disabled
firefox89 --- disabled
firefox90 --- disabled
firefox91 --- affected

People

(Reporter: ahal, Assigned: cmartin)

References

Details

Note: This bug was filed automatically via script.

The following tests are being disabled in browser/components/resistfingerprinting/test/mochitest/mochitest.ini due to new fission xorigin platform triage:

  • test_hide_gamepad_info.html

Full diff:

# HG changeset patch
# User Andrew Halberstadt <ahal@mozilla.com>
# Date 1623334309 14400
#      Thu Jun 10 10:11:49 2021 -0400
# Node ID e39e86e6c0efa60d46df3096c00c2204bc4cd673
# Parent  e77eb14241b9e712ddda1e8c1cc21ef455377e3c
Bug 1700781 - [ci] Run mochitest-plain fission xorigin tasks on more platforms

This revision makes the following changes on central:
+test-linux1804-64-qr/debug-mochitest-plain-fis-xorig-e10s
+test-linux1804-64-shippable-qr/opt-mochitest-plain-fis-xorig-e10s
-test-linux1804-64/debug-mochitest-plain-fis-xorig-e10s
+test-macosx1015-64-qr/debug-mochitest-plain-fis-xorig-e10s
+test-macosx1015-64-shippable-qr/opt-mochitest-plain-fis-xorig-e10s
+test-windows10-64-qr/debug-mochitest-plain-fis-xorig-e10s
+test-windows10-64-shippable-qr/opt-mochitest-plain-fis-xorig-e10s

And adds the following tasks on autoland:
+test-linux1804-64-qr/debug-mochitest-plain-fis-xorig-e10s
+test-linux1804-64-qr/opt-mochitest-plain-fis-xorig-e10s
+test-macosx1015-64-qr/debug-mochitest-plain-fis-xorig-e10s
+test-macosx1015-64-qr/opt-mochitest-plain-fis-xorig-e10s
+test-windows10-64-qr/debug-mochitest-plain-fis-xorig-e10s
+test-windows10-64-qr/opt-mochitest-plain-fis-xorig-e10s

Differential Revision: https://phabricator.services.mozilla.com/D108784

diff --git a/browser/components/resistfingerprinting/test/mochitest/mochitest.ini b/browser/components/resistfingerprinting/test/mochitest/mochitest.ini
--- a/browser/components/resistfingerprinting/test/mochitest/mochitest.ini
+++ b/browser/components/resistfingerprinting/test/mochitest/mochitest.ini
@@ -9,16 +9,18 @@ support-files =
 
 [test_animation_api.html]
 [test_device_sensor_event.html]
 [test_geolocation.html]
 scheme = https
 fail-if = xorigin
 [test_reduce_time_precision.html]
 [test_hide_gamepad_info.html]
+skip-if =
+  fission && xorigin  # {bug} - New fission platform triage
 support-files = test_hide_gamepad_info_iframe.html
 scheme = https
 [test_keyboard_event.html]
 [test_pointer_event.html]
   support-files =
     ../../../../../dom/events/test/pointerevents/mochitest_support_external.js
 [test_speech_synthesis.html]
 skip-if = verify

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 browser/components/resistfingerprinting/test/mochitest/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

Fission Milestone: --- → ?
Component: Privacy: Anti-Tracking → DOM: Device Interfaces

I think these browser/components/resistfingerprinting/test/mochitest/test_hide_gamepad_info.html failures are bug 1714703.

Component: DOM: Device Interfaces → Privacy: Anti-Tracking
Depends on: 1714703
Summary: Tests skipped in 'browser/components/resistfingerprinting/test/mochitest/mochitest.ini' for new fission xorigin platform triage → Fix browser/components/resistfingerprinting/test/mochitest/test_hide_gamepad_info.html test skipped in 'browser/components/resistfingerprinting/test/mochitest/mochitest.ini' for fission xorigin

@ Chris, here's another gamepad test failure related to Fission+xorigin test mode.

Since privacy.resistFingerprinting mode is preffed off by default in Firefox (but enabled by default in Tor), fixing this test doesn't need to block shipping Fission. I will add this bug to Fission's "Future" backlog.

Assignee: nobody → cmartin
Fission Milestone: ? → Future
Flags: needinfo?(cmartin)

Just clearing the NI on this. It's assigned to me, so I will try and work on it the next time I get some cycles for Gamepad-related work.

Flags: needinfo?(cmartin)
You need to log in before you can comment on or make changes to this bug.