1716406 - Tests skipped in 'dom/security/test/csp/mochitest.ini' for new fission xorigin platform triage

Status: NEW

(Core :: DOM: Security, task, P3)

Description

[Andrew Halberstadt [:ahal]]

Note: This bug was filed automatically via script.

The following tests are being disabled in dom/security/test/csp/mochitest.ini due to new fission xorigin platform triage:

• test_bug663567.html
• test_iframe_sandbox_srcdoc.html
• test_iframe_sandbox.html
• test_hash_source.html

Full diff:

diff --git a/dom/security/test/csp/mochitest.ini b/dom/security/test/csp/mochitest.ini
--- a/dom/security/test/csp/mochitest.ini
+++ b/dom/security/test/csp/mochitest.ini
@@ -244,16 +244,18 @@ prefs =
 
 [test_base-uri.html]
 [test_blob_data_schemes.html]
 [test_connect-src.html]
 [test_CSP.html]
 [test_bug1452037.html]
 [test_allow_https_schemes.html]
 [test_bug663567.html]
+skip-if =
+  fission && xorigin && debug && os == "win"  # {bug} - New fission platform triage
 [test_bug802872.html]
 [test_bug885433.html]
 [test_bug888172.html]
 [test_bug1505412.html]
 skip-if = !debug
 [test_evalscript.html]
 [test_evalscript_blocked_by_strict_dynamic.html]
 [test_evalscript_allowed_by_strict_dynamic.html]
@@ -274,16 +276,18 @@ skip-if = verify
 [test_bug1579094.html]
 [test_frame_ancestors_ro.html]
 [test_policyuri_regression_from_multipolicy.html]
 [test_nonce_source.html]
 [test_nonce_redirects.html]
 [test_bug941404.html]
 [test_form-action.html]
 [test_hash_source.html]
+skip-if =
+  fission && xorigin && debug  # {bug} - New fission platform triage
 [test_scheme_relative_sources.html]
 [test_ignore_unsafe_inline.html]
 skip-if = xorigin # JavaScript error: http://mochi.xorigin-test:8888/tests/SimpleTest/TestRunner.js, line 157: SecurityError: Permission denied to access property "wrappedJSObject" on cross-origin object, [Child 3789, Main Thread] WARNING: NS_ENSURE_TRUE(request) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsLoadGroup.cpp, line 591
 [test_self_none_as_hostname_confusion.html]
 [test_empty_directive.html]
 [test_path_matching.html]
 [test_path_matching_redirect.html]
 [test_report_uri_missing_in_report_only_header.html]
@@ -318,29 +322,33 @@ fail-if = xorigin
 [test_fontloader.html]
 [test_block_all_mixed_content.html]
 tags = mcb
 [test_block_all_mixed_content_frame_navigation.html]
 tags = mcb
 [test_form_action_blocks_url.html]
 [test_meta_whitespace_skipping.html]
 [test_iframe_sandbox.html]
+skip-if =
+  fission && xorigin && debug && (os == "win" || os == "linux")  # {bug} - New fission platform triage
 [test_iframe_sandbox_top_1.html]
 [test_sandbox.html]
 [test_ping.html]
 [test_sendbeacon.html]
 [test_upgrade_insecure_docwrite_iframe.html]
 [test_bug1242019.html]
 [test_bug1312272.html]
 [test_strict_dynamic.html]
 [test_strict_dynamic_parser_inserted.html]
 [test_strict_dynamic_default_src.html]
 [test_upgrade_insecure_navigation.html]
 [test_punycode_host_src.html]
 [test_iframe_sandbox_srcdoc.html]
+skip-if =
+  fission && xorigin && debug && os == "win"  # {bug} - New fission platform triage
 [test_iframe_srcdoc.html]
 [test_image_nonce.html]
 [test_websocket_self.html]
 skip-if = toolkit == 'android' # no websocket support Bug 982828
 [test_ignore_xfo.html]
 skip-if = xorigin # JavaScript error: http://mochi.xorigin-test:8888/tests/SimpleTest/TestRunner.js, line 157: SecurityError: Permission denied to access property "wrappedJSObject" on cross-origin object
 [test_data_csp_inheritance.html]
 [test_data_csp_merge.html]

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 dom/security/test/csp/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

Comment 1

[Chris Peterson [:cpeterson]]

test_bug663567.html

I don't see any test_bug663567.html failures in comment 0's try push or some other recent Fission+xorigin try pushes. This skip-if annotation can probably just be removed.

test_iframe_sandbox_srcdoc.html

I don't see a test_iframe_sandbox_srcdoc.html failure in comment 0's try push, but here is a failure in another recent Fission+xorigin try push:

https://treeherder.mozilla.org/push-health/push?repo=try&revision=98cb3d8cc00edc7413103ff841157c7d82216cac&testGroup=pr&selectedTest=domsecuritytestcsptestiframesandboxsrcdochtml&selectedTaskId=342738103&selectedJobName=dom%2Fsecurity%2Ftest%2Fcsp%2Ftest_iframe_sandbox_srcdoc.html+test-windows10-64-qr%2Fdebug-mochitest-plain-fis-xorig-e10s-4

Looks like a LinkedList<js::ParseTask> assertion failure it is being destroyed while not empty:

https://treeherder.mozilla.org/logviewer?job_id=342738103&repo=try&lineNumber=23292

INFO - GECKO(4368) | WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!
INFO - GECKO(4368) | Hit MOZ_CRASH(mozilla::LinkedList<js::ParseTask>::~LinkedList() [T = js::ParseTask] has a buggy user: it should have removed all this list's elements before the list's destruction) at /builds/worker/workspace/obj-build/dist/include/mozilla/LinkedList.h:444
INFO - TEST-UNEXPECTED-ERROR | dom/security/test/csp/test_iframe_sandbox_srcdoc.html | unexpected-crash-dump-found - This test left crash dumps behind, but we weren't expecting it to!
INFO - TEST-UNEXPECTED-CRASH | dom/security/test/csp/test_iframe_sandbox_srcdoc.html | Finished in 242ms

test_iframe_sandbox.html

Looks like the same LinkedList<js::ParseTask> assertion failure as test_iframe_sandbox_srcdoc.html:

https://treeherder.mozilla.org/logviewer?job_id=342418401&repo=try&lineNumber=8125

INFO - GECKO(5090) | WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!
INFO - GECKO(5090) | Hit MOZ_CRASH(mozilla::LinkedList<js::ParseTask>::~LinkedList() [T = js::ParseTask] has a buggy user: it should have removed all this list's elements before the list's destruction) at /builds/worker/workspace/obj-build/dist/include/mozilla/LinkedList.h:444
INFO - TEST-UNEXPECTED-ERROR | dom/security/test/csp/test_iframe_sandbox.html | unexpected-crash-dump-found - This test left crash dumps behind, but we weren't expecting it to!
INFO - TEST-UNEXPECTED-CRASH | dom/security/test/csp/test_iframe_sandbox.html | Finished in 3730ms

test_hash_source.html

I don't see any test_hash_source.html failures in comment 0's try push or some other recent Fission+xorigin try pushes. This skip-if annotation can probably just be removed.

Comment 2

[Chris Peterson [:cpeterson]]

To my untrained eye, these failures don't look Fission problems, just some memory leaks detected at shutdown (and two false positive annotations that can probably just be removed). Deferring to Fission Milestone "Future" for now.

The LinkedList<js::ParseTask> leaks look like bug 1678774, which do seem to happen more frequently for Fission-enabled tests.