Closed Bug 1716407 Opened 3 years ago Closed 3 years ago

Fix and re-enable tests skipped in 'dom/tests/mochitest/gamepad/mochitest.ini' for fission xorigin

Categories

(Core :: DOM: Device Interfaces, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1718221
Fission Milestone MVP
Tracking Status
firefox91 --- affected

People

(Reporter: ahal, Assigned: cmartin)

References

Details

Note: This bug was filed automatically via script.

The following tests are being disabled in dom/tests/mochitest/gamepad/mochitest.ini due to new fission xorigin platform triage:

  • test_gamepad_extensions.html
  • test_navigator_gamepads.html
  • test_gamepad.html

Full diff:

diff --git a/dom/tests/mochitest/gamepad/mochitest.ini b/dom/tests/mochitest/gamepad/mochitest.ini
--- a/dom/tests/mochitest/gamepad/mochitest.ini
+++ b/dom/tests/mochitest/gamepad/mochitest.ini
@@ -3,21 +3,27 @@ scheme = https
 support-files =
   gamepad_frame.html
   gamepad_frame_state.html
   mock_gamepad.js
 
 [test_check_timestamp.html]
 support-files = test_check_timestamp_iframe.html
 [test_gamepad.html]
+skip-if =
+  fission && xorigin  # {bug} - New fission platform triage
 support-files = test_gamepad_iframe.html
 [test_gamepad_connect_events.html]
 support-files = test_gamepad_connect_events_iframe.html
 [test_gamepad_extensions.html]
+skip-if =
+  fission && xorigin  # {bug} - New fission platform triage
 support-files = test_gamepad_extensions_iframe.html
 [test_gamepad_frame_state_sync.html]
 support-files = test_gamepad_frame_state_sync_iframe.html
 [test_gamepad_hidden_frame.html]
 support-files = test_gamepad_hidden_frame_iframe.html
 [test_gamepad_multitouch_crossorigin.html]
 support-files = test_gamepad_multitouch_crossorigin_iframe.html
 [test_navigator_gamepads.html]
+skip-if =
+  fission && xorigin  # {bug} - New fission platform triage
 support-files = test_navigator_gamepads_iframe.html

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 dom/tests/mochitest/gamepad/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

I think this bug is a duplicate of bug 1714702.

INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/gamepad/test_gamepad.html | Test timed out. -
INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/gamepad/test_gamepad.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once. Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/gamepad/test_gamepad_extensions.html | Test timed out. -
INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/gamepad/test_navigator_gamepads.html | Test timed out. -
Type: task → defect
Fission Milestone: --- → ?
Depends on: 1714702

I am still searching for someone to own this bug. Stay tuned...

Some test_gamepad.html failures from bug 1714702 this week:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1714702&startday=2021-06-14&endday=2021-06-20&tree=all

And a test_gamepad_extensions.html failure:
https://treeherder.mozilla.org/logviewer?job_id=342000213&repo=try&lineNumber=26842

And a test_navigator_gamepads.html failure:

https://treeherder.mozilla.org/logviewer?job_id=342000213&repo=try&lineNumber=26902

Fission Milestone: ? → M8
Summary: Tests skipped in 'dom/tests/mochitest/gamepad/mochitest.ini' for new fission xorigin platform triage → Fix and re-enable tests skipped in 'dom/tests/mochitest/gamepad/mochitest.ini' for fission xorigin

Marcos, I see you just landed a gamepad test fix in bug 1714703 and that you hope (bug 1714702 comment 4) it might fix test_gamepad.html bug 1714702.

If you have time, can you please try testing whether your fix also fixes these three gamepad tests skipped for fission && xorigin mode in dom/tests/mochitest/gamepad/mochitest.ini? In the meantime, I'm trying to find an engineer inside Mozilla to investigate these gamepad test failures.

https://searchfox.org/mozilla-central/rev/f213971fbd82ada22c2c4e2072f729c3799ec563/dom/tests/mochitest/gamepad/mochitest.ini#10-12,16-18,26-28

I am moving this bug from Fission Milestone M8 to MVP because these gamepad test failures don't need to block Fission's Release channel experiment, but it would be nice to fix them before we ship Fission MVP.

Fission Milestone: M8 → MVP
Flags: needinfo?(marcos)
See Also: → 1714703

Tentatively assigning this bug to Chris Martin.

@ Chris, these gamepad tests fail in Fission+xorigin test mode. Marcos thinks his fix for bug 1714703 might fix related gamepad test bug 1714702. Perhaps his fix will also help this bug?

Assignee: nobody → cmartin
Flags: needinfo?(cmartin)

Just acknowledging the request. Will do my best try the above this week. Leaving need info so I don't forget.

Hi Baku, Chris,
Did some experimenting... it appears that when when fission is enabled, then Permissions Policy (with respect to html's allow= attribute) stops working, and we get:

JavaScript error: https://example.org/tests/browser/components/resistfingerprinting/test/mochitest/test_hide_gamepad_info_iframe.html, line 34: SecurityError: Navigator.getGamepads: Document's Permission Policy does not allow calling getGamepads() from this context. 

Baku - is this a known issue?

(The test above works fine when fission is not enabled).

Flags: needinfo?(marcos) → needinfo?(amarchesini)

I re-enabled the tests as part of https://phabricator.services.mozilla.com/D119471 ... should hopefully be ok now.

Flags: needinfo?(amarchesini)

(In reply to marcos from comment #7)

I re-enabled the tests as part of https://phabricator.services.mozilla.com/D119471 ... should hopefully be ok now.

Thanks! I will close this bug as a duplicate of the gamepad bug you fixed (bug 1718221).

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(cmartin)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.