Closed Bug 1716466 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29376 - Do not require validation messages to have a parent at all times

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29376 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29376
Details from upstream follow.

b'Aaron Leventhal <aleventhal@google.com>' wrote:

Do not require validation messages to have a parent at all times

Validation messages are presented at the top of a document when there
is invalid entry in a form. The accessibility object for these is only
created once, and either added or removed from the root object's
children depending on whether it's currently visible. This can lead
to a situation where it's marked dirty and the serializer tries to use
it, even when it's not currently part of the tree.

This CL removes the requirement for it to have a parent, in order to
avoid DCHECK()s that require all objects but the root to have a parent,
and repairs missing parents.

Another solution could be to detach and remove the validation message
object (validation_message_axid_), when it is not in use, and create
a new one each time one is needed.

Fixed: 1216847
Change-Id: I009ee1d2c46ad989182a0a4ff0c11381508a77c1
Reviewed-on: https://chromium-review.googlesource.com/2961162
WPT-Export-Revision: 4a61b566f37fdbf56c6cd6f62c96f6057efb6d2c

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa52d3a8f18f
[wpt PR 29376] - Do not require validation messages to have a parent at all times, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.