1716529 - Defer creating allocation sites until running in baseline

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Jon Coppeard (:jonco)]

Currently we create allocation sites when attaching cache IR stubs which can happen when code is running in the baseline interpreter. It would be preferable to defer this until the code is hot enough to run in baseline proper, to avoid overhead for code that is not particularly hot.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1716529 - Don't create allocation sites until baseline r?jandem

This stops creating allocation sites for IC stubs when running in the baseline
interpreter. When a script is compiled in baseline proper this scans the IC
chain for ops that could potentially reference allocation sites, and allocates
them where necessary.

This should result in fewer sites being created and less overhead for code that
doesn't reach baseline.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1716529 - Don't create allocation sites until baseline r?jandem

This stops creating allocation sites for IC stubs when running in the baseline
interpreter. When a script is compiled in baseline proper this scans the IC
chain for ops that could potentially reference allocation sites, and allocates
them where necessary.

This should result in fewer sites being created and less overhead for code that
doesn't reach baseline.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/360ca5ba051e
Don't create allocation sites until baseline r=jandem

Comment 4

[Iulian Moraru]

Backed out for causing spidermonkey build bustages.

Push with failures

Failure log

Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff54f41b526b
Don't create allocation sites until baseline r=jandem

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ff54f41b526b