1716543 - Annotate nsStandardURL::SanityCheck crash reports

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1716543 - Annotate nsStandardURL::SanityCheck with URL offsets r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0da59114555d
Annotate nsStandardURL::SanityCheck with URL offsets r=necko-reviewers,kershaw

Comment 3

[Julien Cristau [:jcristau]]

Shouldn't this get data review?

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: crashannotation_URLSegments_datarequest.md

Thanks for the heads-up. This is my first time adding an annotation.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0da59114555d

Comment 6

[Chris H-C :chutten]

Comment on attachment 9227668 [details]
crashannotation_URLSegments_datarequest.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Valentin Gosu is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9227164 [details]
Bug 1716543 - Annotate nsStandardURL::SanityCheck with URL offsets r=#necko

Beta/Release Uplift Approval Request

• User impact if declined: Lack of visibility into reason for nsStandardURL sanity check assertions (bug 1715960)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This code path already crashes (intentionally). This patch merely adds relevant offsets to the crash annotations.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9227164 [details]
Bug 1716543 - Annotate nsStandardURL::SanityCheck with URL offsets r=#necko

approved for 90.0b11

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d5475361ed0