1716588 - Crash in [@ core::option::expect_failed | std::time::{{impl}}::sub]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

11 crashes from ~9 installations, most on Windows 10.

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/288b61d0-dd5d-4fb7-a9ef-ab2510210609

MOZ_CRASH Reason: supplied instant is later than self

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn ../88f19c6dab716c6281af7602e30f413e809c5974/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../88f19c6dab716c6281af7602e30f413e809c5974//library/std/src/panicking.rs:595
4 xul.dll std::panicking::begin_panic_handler::{{closure}} ../88f19c6dab716c6281af7602e30f413e809c5974//library/std/src/panicking.rs:497
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<closure-0, !> ../88f19c6dab716c6281af7602e30f413e809c5974//library/std/src/sys_common/backtrace.rs:141
6 xul.dll std::panicking::begin_panic_handler ../88f19c6dab716c6281af7602e30f413e809c5974//library/std/src/panicking.rs:493
7 xul.dll core::panicking::panic_fmt ../88f19c6dab716c6281af7602e30f413e809c5974//library/core/src/panicking.rs:92
8 xul.dll core::option::expect_failed ../88f19c6dab716c6281af7602e30f413e809c5974//library/core/src/option.rs:1321
9 xul.dll std::time::{{impl}}::sub ../88f19c6dab716c6281af7602e30f413e809c5974//library/std/src/time.rs:407

Comment 1

[Dragana Damjanovic [:dragana]]

PR 1163 should fix this. It needs an neqo update.

Comment 2

[Dragana Damjanovic [:dragana]]

There are 2 different crashes here, one only affects Nightly and PR 1163 should fix that one. I will try to fix the other type of crash as well.

Comment 3

[Chris Peterson [:cpeterson]]

Adding [not-a-fission-bug] whiteboard tag because this doesn't look like a Fission bug, even though some of the recent crash reports (including comment 0's) have "DOMFissionEnabled=1".

Comment 4

[Dragana Damjanovic [:dragana]]

This is fixed bug neqo update in bug 1717505. The update contains PR 1163 and PR 1164. The PRs should fix 2 bug: one is Nightly only and the other is occurring on release as well.