Closed Bug 1716599 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29388 - Use GetWithoutInvalidation() instead of Get() in DCHECKs

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox91 fixed)

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29388 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29388
Details from upstream follow.

b'Aaron Leventhal <aleventhal@google.com>' wrote:

Use GetWithoutInvalidation() instead of Get() in DCHECKs

We should never call Get() inside of a DCHECK(), because this can
lead to a different code path depending on whether DCHECKs are enabled.

Bug: 1219311
Change-Id: Iafaa289f241a851404ce352715d2970172a2e5f8

Reviewed-on: https://chromium-review.googlesource.com/2961158
WPT-Export-Revision: 87dbf8e79d4c618e156e60d6b22c69172c40621b

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c4812ce21f0
[wpt PR 29388] - Safe slot reassigment, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6c4812ce21f0

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.