Closed Bug 1716690 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29395 - [css-flex] Add support for newer css-align-3 keywords

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29395 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29395
Details from upstream follow.

b'David Grogan <dgrogan@chromium.org>' wrote:

[css-flex] Add support for newer css-align-3 keywords

Specifically start, end, self-start, self-end, left, right

I used two chokepoints (ResolvedJustifyContent and AlignmentForChild) to
translate kSelfStart, kSelfEnd, kLeft, and kRight to
k{Flex}?[End|Start], which callers mostly already support.
AlignmentForChild also translates kStart and kEnd to kFlexStart and
kFlexEnd. But callers to ResolvedJustifyContent have to handle kStart
and kEnd on their own.

https://www.chromestatus.com/feature/5777880099323904

Bug: 1011718
Change-Id: Ic7ea9bfda9e3e11bcb622358b55dce9f6971cbe0
Reviewed-on: https://chromium-review.googlesource.com/2959465
WPT-Export-Revision: b3eae7cbee0699efbd3c1b53ff663a0859061bfe

PR 29395 applied with additional changes from upstream: 38ba3d82c68c3f79d9a24350ff1960a493c65d5c
Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a678b5894f1f
[wpt PR 29395] - [css-flex] Add support for newer css-align-3 keywords, a=testonly
https://hg.mozilla.org/integration/autoland/rev/bbe68c6a2592
[wpt PR 29395] - Update wpt metadata, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.