Closed
Bug 1716827
Opened 3 years ago
Closed 3 years ago
Update success-animation.svg to be consistent with Proton check.svg
Categories
(Firefox :: Theme, task)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: bigiri, Assigned: sfoster)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-cleanups][proton-icons])
Attachments
(1 file)
The success-animation.svg does not match the Proton styling of chrome/toolkit/skin/classic/global/icons/check.svg resulting in inconsistent appearance. This svg needs to be regenerated or replaced with a more consistent image.
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1878
|
Reporter | |
Updated•3 years ago
|
Blocks: proton-cleanups
|
|
Reporter | |
Updated•3 years ago
|
Blocks: proton-icons
|
Assignee | |
Comment 1•3 years ago
|
||
This is the animation used in the confirmation prompt.
A quick way to trigger that in the browser console:
ConfirmationHint.show(document.getElementById("PanelUI-menu-button"), "pageBookmarked2")
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
- Use the new path from check.svg in each frame
- Use clip-paths rather than the mask & stroke-width properties to do the clipping in each frame
- Pick up the fill (white) color from CSS using currentColor rather than hardcoding in the SVG
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35bff5173880 Update the success checkbox animation. r=dao
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•