Closed Bug 1716830 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29400 - Throw error if connections are made between different contexts

Categories

(Core :: Web Audio, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 29400 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29400
Details from upstream follow.

b'Raymond Toy <rtoy@chromium.org>' wrote:

Throw error if connections are made between different contexts

The WebAudio spec says that if a node is connected/disconnected to
another node or AudioParam that belongs to a different context, then
an InvalidStateError must be thrown. Add a check for this and throw
the required error.

This also requires a fix to audit.js which wasn't properly catching
DOM exceptions of the wrong type.

Finally, ctor-channelsplitter.html needed to be updated to specify the
error type because of the change in audit.js.

Bug: 1206927
Change-Id: I320425268d1fd243e347dd36c79172c69dcc9733
Reviewed-on: https://chromium-review.googlesource.com/2965479
WPT-Export-Revision: 1a07315958bf66511e7cd3dde66c0499b9e87292

Component: web-platform-tests → Web Audio
Product: Testing → Core
Attached file Notable wpt changes
# CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 197 tests and 7 subtests

## Status Summary

### Firefox
OK     : 189[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt] 192[GitHub]
PASS   : 5635[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-tsan-opt] 5639[Gecko-android-em-7.0-x86_64-opt-geckoview] 5643[Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 5644[GitHub] 5659[Gecko-linux1804-64-qr-debug]
FAIL   : 432[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt] 439[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 448[GitHub]
TIMEOUT: 6
ERROR  : 4
NOTRUN : 14

### Chrome
OK     : 197
PASS   : 6708
FAIL   : 24

### Safari
OK     : 185
PASS   : 6581
FAIL   : 73
TIMEOUT: 21
ERROR  : 3
NOTRUN : 13

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bafadd4608f62ae4d53fd8540629483a2f88e10)
[GitHub PR Head](https://wpt.fyi/results/?sha=28c6619a2b06b9fcb36361a11ae23ca040468283&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=28c6619a2b06b9fcb36361a11ae23ca040468283&label=pr_base)

## Details

### Firefox-only Failures
/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiosource-time-limits.html
  Executing "buffersource: huge stop time": FAIL
  Executing "oscillator: huge stop time": FAIL
/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-suspend-resume.html
  Executing "test-suspend": FAIL
  Executing "test-after-close": TIMEOUT
/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam.html
  Executing "disconnect(AudioParam)": FAIL
  Executing "disconnect(AudioParam, output)": FAIL
/webaudio/the-audio-api/the-audioparam-interface/adding-events.html
  Executing "linearRamp": FAIL
  Executing "expoRamp": FAIL
/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold.html
  Executing "linear": FAIL
  Executing "exponential": FAIL
  Executing "setTarget": FAIL
  Executing "setValueCurve": FAIL
  Executing "setValueCurve after end": FAIL
  Executing "initial setTarget": FAIL
  Executing "post cancel: Linear": FAIL
  Executing "post cancel: Exponential": FAIL
  Executing "post cancel: ValueCurve": FAIL
  Executing "post cancel: setTarget": FAIL
  Executing "post cancel: setValue": FAIL
  Executing "cancel future setTarget": FAIL
  Executing "cancel setTarget now": FAIL
  Executing "cancel future setValueCurve": FAIL
  Executing "cancel setValueCurve now": FAIL
  Executing "linear, cancel, linear, cancel, linear": FAIL
/webaudio/the-audio-api/the-audioparam-interface/audioparam-large-endtime.html
  Executing "linearRamp": FAIL
  Executing "exponentialRamp": FAIL
/webaudio/the-audio-api/the-audioparam-interface/automation-rate.html
  Executing "AudioListener": FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html
  Executing "Listener x": FAIL
  Executing "Listener y": FAIL
  Executing "Listener z": FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner.html
  Executing "Listener k-rate positionX": FAIL
  Executing "Listener k-rate positionY": FAIL
  Executing "Listener k-rate positionZ": FAIL
  Executing "Listener k-rate forwardX": FAIL
  Executing "Listener k-rate forwardY": FAIL
  Executing "Listener k-rate forwardZ": FAIL
  Executing "Listener k-rate upX": FAIL
  Executing "Listener k-rate upY": FAIL
  Executing "Listener k-rate upZ": FAIL
/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime.html
  Executing "test": FAIL
/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime.html
  Executing "test": FAIL
/webaudio/the-audio-api/the-audioparam-interface/retrospective-setTargetAtTime.html
  Executing "test": FAIL
/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime.html
  Executing "test": FAIL
/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime.html
  Executing "test": FAIL
/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam-size.https.html
  Executing "Verify Size of AudioParam Arrays": FAIL
/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam.https.html
  Executing "Verifying AudioParam in AudioWorkletNode": FAIL
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletglobalscope-timing-info.https.html
  Executing "Check the timing information from AudioWorkletProcessor": FAIL
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-automatic-pull.https.html: TIMEOUT
  Executing "setup-worklet": TIMEOUT
  Audit report: NOTRUN
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-channel-count.https.html: ERROR
  Executing "setup-buffer-and-worklet": TIMEOUT
  Executing "verify-rendered-buffer": NOTRUN
  Audit report: NOTRUN
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-disconnected-input.https.html: ERROR
  Executing "test": TIMEOUT
  Audit report: NOTRUN
/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html
  Executing "Test 0": FAIL
  Executing "Test 1": FAIL
  Executing "Test 2": FAIL
  Executing "Test 3": FAIL
  Executing "Test 4": FAIL
  Executing "Test 5": FAIL
/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect.html
  Executing "silent-disconnect": FAIL
/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan.html
  Executing "delayed buffer set": FAIL
/webaudio/the-audio-api/the-delaynode-interface/no-dezippering.html
  Executing "test0": FAIL
  Executing "test1": FAIL
  Executing "test2": FAIL
/webaudio/the-audio-api/the-gainnode-interface/no-dezippering.html
  Executing "test0": FAIL
  Executing "test2": FAIL
  Executing "test3": FAIL
/webaudio/the-audio-api/the-pannernode-interface/automation-changes.html
  Executing "Set Listener.positionX.value": FAIL
  Executing "Listener.positionX.setValue": FAIL
  Executing "Listener.setPosition": FAIL
/webaudio/the-audio-api/the-pannernode-interface/ctor-panner.html
  Executing "default constructor": FAIL
/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic.html
  Executing "Stereo panner.positionX": FAIL
  Executing "Mono panner.positionX": FAIL
  Executing "Stereo panner.positionY": FAIL
  Executing "Mono panner.positionY": FAIL
  Executing "Stereo panner.positionZ": FAIL
  Executing "Mono panner.positionZ": FAIL
  Executing "Stereo listener.positionX": FAIL
  Executing "Mono listener.positionX": FAIL
  Executing "Stereo listener.positionY": FAIL
  Executing "Mono listener.positionY": FAIL
  Executing "Stereo listener.positionZ": FAIL
  Executing "Mono listener.positionZ": FAIL
  Executing "setPosition": FAIL
  Executing "orientation setter": FAIL
  Executing "forward setter": FAIL
  Executing "up setter": FAIL
/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position.html: ERROR
  Executing "0: 1-channel inverse rolloff: 1": TIMEOUT
  Executing "0: 2-channel inverse rolloff: 1": NOTRUN
  Executing "1: 1-channel inverse rolloff: 1": NOTRUN
  Executing "1: 2-channel inverse rolloff: 1": NOTRUN
  Executing "2: 1-channel exponential rolloff: 1.5": NOTRUN
  Executing "2: 2-channel exponential rolloff: 1.5": NOTRUN
  Executing "3: 1-channel linear rolloff: 1": NOTRUN
  Executing "3: 2-channel linear rolloff: 1": NOTRUN
  Audit report: NOTRUN
/webaudio/the-audio-api/the-pannernode-interface/pannernode-basic.html
  Executing "listener": FAIL
/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering.html
  Executing "test mono input": FAIL
  Executing "test stereo input": FAIL
  Executing "test mono input setValue": FAIL
  Executing "test stereo input setValue": FAIL
  Executing "test mono input automation": FAIL
/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve.html
  Executing "test copying": FAIL

(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e84a684957d
[wpt PR 29400] - Throw error if connections are made between different contexts, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: