1716833 - [XFA] Code-like text paragraphs are incorrectly underlined

Status: NEW

(Firefox :: PDF Viewer, defect, P2)

Description

[Daniel Bodea [:danibodea]]

Attachment: 2e5e4a8e-1d8d-484e-be62-ec0736bee620.pdf

Note

• When the user loads a specific PDF that has a code-like text paragraph, he will notice that the whole paragraph is being underlined.

Affected versions

• Nightly v91.0a1

Affected platforms

• all

Steps to reproduce

1. Launch browser.
2. Flip the pdfjs.enableXfa to true.
3. Load the attached PDF file.
4. Observe the code-like paragraphs.

Expected result

• The code-like paragraphs are not being underlined.

Actual result

• The code-like paragraphs are displayed as underlined.

Regression range

• Not a recent regression, but an implementation flaw.
• I have to mention that in Beta v90.0b6 and v90.0b8, 6 out of 7 pages are being displayed (compared to how Adobe Reader loads it), but most of the page elements are missing.

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: code-like paragraphs are underligned.png

Comment 2

[Calixte Denizet (:calixte)]

This is because a container has a font with the underline property and a sub-container disables it.
But with CSS the sub-container "inherits" the text-decoration but cannot disable it:
https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration

so here we cannot rely on CSS but we must handle inheritance ourselves on the js side.

Comment 4

[Daniel Bodea [:danibodea]]

Recognizing as a generic xfa issue since the blocked bug is 1706133. Please change it if the case.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/13779

Comment 6

[Daniel Bodea [:danibodea]]

Attachment: 3b3890e6-a3b7-43a1-949e-abdb75f3cb36.pdf

The issue is also seen here.

Comment 7

[Daniel Bodea [:danibodea]]

Attachment: underline format issue canada 26.png