1716850 - [Wayland] ERROR: Potential deadlock detected:

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

When popup is closed there's a message on debug build:

###!!! ERROR: Potential deadlock detected:
=== Cyclical dependency starts at
--- Mutex : WindowSurfaceWayland lock calling context
[stack trace unavailable]

--- Next dependency:
--- Mutex : MozContainer lock (currently acquired)
calling context
[stack trace unavailable]

=== Cycle completed at
--- Mutex : WindowSurfaceWayland lock calling context
[stack trace unavailable]

Deadlock may happen for some other execution

[Parent 31358, Main Thread] WARNING: Potential deadlock detected:
Cyclical dependency starts at
Mutex : WindowSurfaceWayland lock
Next dependency:
Mutex : MozContainer lock (currently acquired)
Cycle completed at
Mutex : WindowSurfaceWayland lock
Deadlock may happen for some other execution

: file /raid/src3/xpcom/threads/BlockingResourceBase.cpp:247

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1716850 [Wayland] Don't lock WindowSurfaceWayland at WindowSurfaceWayland::Reset(), r?rmader

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1716850 [Wayland] Call WindowSurfaceWayland::Reset() from moz_container_wayland_surface_create_locked(), r?rmader

Depends on D118078

Comment 3

[Robert Mader [:rmader]]

For the record, issues like these make me even more eager to land bug 1708416 so we can hopefully avoid some complexity involved here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09e90d1b7c7b
[Wayland] Don't lock WindowSurfaceWayland at WindowSurfaceWayland::Reset(), r=rmader
https://hg.mozilla.org/integration/autoland/rev/8f1b77b41092
[Wayland] Call WindowSurfaceWayland::Reset() from moz_container_wayland_surface_create_locked(), r=rmader

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/09e90d1b7c7b
https://hg.mozilla.org/mozilla-central/rev/8f1b77b41092

Comment 6

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1716563