[wpt-sync] Sync PR 29403 - Properly disallow custom layout + multicol.
Categories
(Core :: Layout, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 29403 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/29403
Details from upstream follow.
b'Morten Stenshorne <mstensho@chromium.org>' wrote:
Properly disallow custom layout + multicol.
Checking LayoutObject type won't do, since we don't always create a
LayoutNGCustom object (e.g. if it's a DETAILS element (but, then again,
should we allow custom layout on those???)). Check display type instead.The reason for the crash was that we ended up creating a
LayoutNGBlockFragmentation multicol container inside a legacy multicol
container, even when LayoutNGBlockFragmentation is disabled (custom
layout forces LayoutNG). We don't create a paint layer on the flow
thread (nor the multicol container) in LayoutNGBlockFragmentation, which
the legacy pre-paint code assumes.Bug: 1219874
Change-Id: I26fcd8d4a5fd51ce1799b207bf39b8e322890ca9Reviewed-on: https://chromium-review.googlesource.com/2964675
WPT-Export-Revision: 348d3d698b44fca4f52dd30560415a9423fa8193
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=aeb37376889da947c483a72b42aad235b09e6f1a
Assignee | ||
Comment 2•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=817b127c3903bdf784dd803b6350745030511158
Assignee | ||
Comment 3•3 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS : 1
Chrome
CRASH: 1
Safari
PASS : 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4106a104a48 [wpt PR 29403] - Properly disallow custom layout + multicol., a=testonly
Comment 5•3 years ago
|
||
bugherder |
Description
•