recommended install cmd for browser/components/newtab/node_modules doesn't work on Win10
Categories
(Firefox :: Messaging System, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: dmosedale, Assigned: emcminn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
./mach npm install --prefix=browser/components/newtab, which comes straight from https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/index.html has various problems on Windows 10. Among others it doesn't want to install the dev-dependencies.
The simplest workaround is to, instead, do this:
(cd browser/components/newtab && ../../../mach npm install)
Why this is happening is unclear. Probably the simplest thing to do is to update the docs.
This may or may not be related to the Node 12 upgrade; I'm not sure.
|
||
Comment 2•3 years ago
|
||
It might also be an idea to use npm ci, since that avoids npm changing the package-lock.json (which then do sometimes end up in patches).
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
I'm going to start with updating the docs & we can go from there if we learn anything new!
|
|
Assignee | |
Comment 4•3 years ago
|
||
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/835b9f84f1bb Update newtab source docs with correct instructions for npm install r=dmose
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
|
||
Updated•2 years ago
|
Description
•