171700 - External apps may open tabs in crippled windows

Status: RESOLVED WORKSFORME

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[cmiller]

If Chimera is set to open pages from external apps in a new tab, that tab may be
created in a Javascript-opened window that has no toolbar, no scrollbar, or is
not resizable, with no way of fixing it except opening a new window and
re-triggering the URL.

Chimera should ignore "crippled" windows when determining where to open the new
page.

Comment 1

[Greg K.]

Reporter, what build ID are you reporting this bug against? What application is
sending the URL to Chimera? Starting with Chimera not running, what steps do you
take to reproduce the bug?

Comment 2

[cmiller]

Okay, here goes with the long version.

* Steps to reproduce:

1. Open Chimera
2. Set Tabbed browsing prefs to load pages in new tabs when requested by another
application. (Manually confirm that the preference has worked - I found I needed
to open a tab manually before the preference took hold, until then it kept
opening in new windows, but that is possibly another bug.)
3. Go to http://www.pastiche.org/~cmiller/chimtabtest.html (source below), and
click on the "Click Me" link. This will open a 100x100 window with no toolbars
or scrollbars.
4. Without changing the active window in Chimera, Run the AppleScript listing
below in Script Editor. (The script just triggers the standard AppleEvent for
opening a new URL in the browser, I originally encountered this problem using
NetNewsWire Lite - http://ranchero.com/software/netnewswire/ )

* Outcome:

The URL opened by the AppleScript is stuck in a new tab in an unresizable
100x100 window, and can not escape.

* Environment:
September 30th nightly build (2002093004), on a G4 Powerbook running Mac OS X 10.2.1

* Contents of chimtabtest.html:

<a href="#"
onClick="window.open('blah.html','blah','width=100,height=100')">Click Me</a>

* Contents of blah.html:

<h1>blah</h1>

* AppleScript used for testing:

tell application "Navigator"
     activate
     open url "http://www.mozilla.org"
end tell

Comment 3

[cmiller]

Correction. The 100x100 window _can_ be resized, it just doesn't have the
resizing grippy decorating the window. There is, however, no way to get the
toolbar back into the window, as View->Show Toolbar remains inactive.

Comment 4

[Greg K.]

Ah, I see. This could happen in any pop-up window, basically. Some possible
solutions include.

 A. Refuse to automatically open new tabs in windows with toolbars disabled
 B. Allow toolbars to me made visible once a window gets more than one tab
 C. Always allow toolbars to be made visible, even in toolbar-less windows.

Reassigning to Tabbed Browsing.

Comment 5

[sairuh (rarely reading bugmail)]

->smfr, since i think he was going to work on related stuff. (but punt as needed.)

Comment 6

[L. H.]

Attachment: Test case

WFM with 2005021708:
1) open test case and popup window
2) in Terminal run: osascript -e 'tell application "Camino" to open location
"www.mozilla.org"'

The new tab ignores the popup and is opened in the frontmost chromed window.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Indeed, it looks like some "recent" change makes this WFM.  In addition to the
new testcase, I tried with a weblogs.mozillazine.org Trackback window top-most
and double-clicked a link in a message in Eudora, which had been problematic before.

The Firefox (bug 243893) and core (bug 143866) bugs are still open, with no
checkins, though.

We can still open tabs *manually* in crippled windows, but with "Move tab to new
window" and the fact Camino shows the tabbar where Fx apparently does not in
this situation makes that part less of an issue.

Comment 8

[L. H.]

(In reply to comment #7)
> We can still open tabs *manually* in crippled windows

But this bug is about external apps.

Manually is not a problem in Camino because the tab bar is still shown, so there
is no reason not to allow users to do it if they specifically want to.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Resolved WFM based on comment 6 and comment 7.