Closed Bug 1717017 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29415 - [aspect-ratio] Fix implicit stretching in both axis (normal alignment).

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29415 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29415
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[aspect-ratio] Fix implicit stretching in both axis (normal alignment).

Previously (within a grid where we have normal alignment in both axes,
but is "stretch") we'd prefer the block-axis size over the inline-axis
size.

This changes the behaviour to prefer the inline-axis size in this case.
This is test 038.html

Wrote a somewhat exhaustive set of tests with the explicit/implicit
stretching which Blink/Gecko basically agree on.

Gecko does well on these set of tests - and only fails 028,029 which
I believe is a variant of the known issue.

Bug: 1045668
Change-Id: I4f6707676a00e75b6aae3005f1d943df20fee02f

Reviewed-on: https://chromium-review.googlesource.com/2967507
WPT-Export-Revision: 04b538409449badb9df63a887945f923d819709b

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests

Status Summary

Firefox

PASS: 9
FAIL: 2

Chrome

PASS: 10
FAIL: 1

Safari

PASS: 2
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-sizing/aspect-ratio/grid-aspect-ratio-028.html: FAIL
/css/css-sizing/aspect-ratio/grid-aspect-ratio-029.html: FAIL

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/grid-aspect-ratio-028.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-sizing/aspect-ratio/grid-aspect-ratio-029.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a67c3a64c3e
[wpt PR 29415] - [aspect-ratio] Fix implicit stretching in both axis (normal alignment)., a=testonly
https://hg.mozilla.org/integration/autoland/rev/557f3c64b599
[wpt PR 29415] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5a67c3a64c3e
https://hg.mozilla.org/mozilla-central/rev/557f3c64b599

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.