1717052 - FirefoxDataProvider shouldn't be reset on target switch

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Alexandre Poirot [:ochameau]]

Currently, we do instantiate FirefoxDataPvovider for each new top level target:
https://searchfox.org/mozilla-central/rev/b172dd415c475e8b2899560e6005b3a953bead2a/devtools/client/netmonitor/src/connector/index.js#168
But we shouldn't, we should instantiate it once. Otherwise we will probably have a hard time catching up the stacktrace for the initial document request.

The only reasons to instantiate it once per top target would be:

• memory: we would ensure clearing maps on navigation. But may be we could do that expliitely instead of destroy and re-create?
• webConsoleFront, which is specific per target. But the console front should be specific per target, we shouldn't pick the top level one. So this isn't a good reason. We should use the console of the target related to the network resource we interact with. And should we use the console front at all? That may be yet another question :)

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1717052 - [devtools] Instantiate FirefoxDataProvider only once.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e555b9256f7f
[devtools] Instantiate FirefoxDataProvider only once. r=bomsy

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e555b9256f7f