1717079 - Clean up the dialog stylesheets and make the dialogs themeable where needed

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

During looking at the dialogs on new AB I found that the dialogs.css stylesheet is almost unneeded. It has only one rule that is used in only one of the referencing dialogs (.wizard-box in importDialog.xhtml). The only thing it did was adding messenger.css.

I removed this stylesheet and directly added messenger.css, which has now the .wizard-box rule, to the dialogs.

During this work I found that we have still dialogs which aren't themeable.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1717079-dialog-clean-up.patch

Removed dialogs.css and made some more dialogs themeable.

sendProgress.xhtml and shutdownWindow.xhtml use now the new progressmeter styling. But I couldn't test shutdownWindow.xhtml as I don't know how to open it (window.openDialog(( doesn't work) or how to trigger it. I've never seen this dialog. If it is never shown, I can remove the changes for it.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1717079-dialog-clean-up.patch

Fixed the commit message.

Comment 3

[Alessandro Castellani [:aleca]]

(In reply to Richard Marti (:Paenglab) from comment #1)

sendProgress.xhtml and shutdownWindow.xhtml use now the new progressmeter styling. But I couldn't test shutdownWindow.xhtml as I don't know how to open it.

Oh yeah, I've never seen that dialog either. It's opened from the nsMsgShutdownService in the nsMsgMailSession.cpp file, but I'm not sure how to trigger it.
Magnus, do you know if the shutdownWindow.xhtml dialog is still use it and how we can trigger it?

Comment 4

[Magnus Melin [:mkmelin]]

I haven't seen it. But looks like if you have send later set to send before shutdown and send something larger you should be able to see it come up until the send has been completed.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9227728 [details] [diff] [review]
1717079-dialog-clean-up.patch

Review of attachment 9227728 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks for going through all these dialogs.

::: mailnews/base/content/msgSynchronize.xhtml
@@ +14,5 @@
>          onload="OnLoad();"
>          style="width: 35em;">
>  <dialog id="msg-synchronizer">
>      <script src="chrome://messenger/content/msgSynchronize.js"/>
> +  <script src="chrome://messenger/content/dialogShadowDom.js"/>

nit: wrong indentation.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1717079-dialog-clean-up.patch

Fixed the indentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b30a0fe37d1c
Clean up the dialog stylesheets and make the dialogs themeable where needed. r=aleca