1717088 - MAPI headers no longer available for download from Microsoft; vendor from MIT license Github project

Status: RESOLVED FIXED

(MailNews Core :: Build Config, task)

Description

[Rob Lemley [:rjl]]

The MAPI Header files download URL is returning a 404 error, despite being linked to from various MSDN documents.

However, the headers have been released under an MIT license as part of the MAPI Stub Library which now lives on Github.

This bug is to vendor these headers into comm-central and update build code to use them rather than the toolchain artifact currently in use.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1717088 - Add MAPI headers to source tree. r=mkmelin

The Outlook 2010 Headers are no longer available for download from Microsoft.
The same files are part of the MAPIStubLibrary under MIT license on Github.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1717088 - Use vendored MAPI header files. r=justdave

Depends on D118278

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1717088 - Remove mapiheaders toolchain job. r=justdave

Depends on D118279

Comment 4

[Rob Lemley [:rjl]]

I compared the header files that I downloaded from Github against the ones I previously dowloaded from Microsoft. There are differences; 99% of those differences amount to whitespace. There is an addition to mapidefs.h. That #ifdef is referring to SAL (MS Source code Annotation Language) and won't have an effect.

Magnus, does this need to run by the licensing team?

--- /home/rob/moz/vs2017_15.8.4/mapiheaders/mapidefs.h	2009-06-02 17:02:36.000000000 -0400
+++ mailnews/mapi/include/mapidefs.h	2021-06-18 17:52:42.912221718 -0400
@@ -94,8 +94,14 @@
 typedef char				TCHAR;
 #endif
 
+
+#if _SAL_VERSION >= 20
+typedef _Null_terminated_ WCHAR FAR *			LPWSTR;
+typedef _Null_terminated_ const WCHAR FAR *	LPCWSTR;
+#else
 typedef WCHAR FAR *			LPWSTR;
 typedef const WCHAR FAR *	LPCWSTR;
+#endif
 typedef TCHAR FAR *			LPTSTR;
 typedef const TCHAR FAR *	LPCTSTR;
 typedef BYTE FAR *

Comment 5

[Magnus Melin [:mkmelin]]

All you need to do is make sure to include the MIT licensing headers.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c09c2688606c
Add MAPI headers to source tree. r=mkmelin
https://hg.mozilla.org/comm-central/rev/a6d5679971b6
Use vendored MAPI header files. r=justdave
https://hg.mozilla.org/comm-central/rev/e9f7d186671b
Remove mapiheaders toolchain job. r=justdave