1717182 - Make nsWindows::mIsRTL dynamic on Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

When RTL mode is changed after window open on HCM, we see 2 caption buttons like the following.
https://bugzilla.mozilla.org/show_bug.cgi?id=1715990#c1

Comment 1

[Sotaro Ikeda [:sotaro]]

On current m-c, nsWindows::mIsRTL is initialized in nsWindow::Create() and it is not updated after the initialization.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1717182 - Make nsWindows::mIsRTL dynamic on Windows

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/064d1e04ff9f
Make nsWindows::mIsRTL dynamic on Windows r=jrmuizel,gfx-reviewers

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/064d1e04ff9f

Comment 5

[Yaron]

Thank you Sotaro.
Can you push it to Firefox 90?

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9227838 [details]
Bug 1717182 - Make nsWindows::mIsRTL dynamic on Windows

Beta/Release Uplift Approval Request

• User impact if declined: 2 caption buttons are shown on top left and top right of a window when Hebrew langpack is installed on English version Firefox during high contrast mode is enabled on Windows 10.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change only made nsWindows::mIsRTL dynamic on Windows. And it affect only when RTL is changed dynamically during high contrast mode on Windows.
• String changes made/needed: none

Comment 7

[Sotaro Ikeda [:sotaro]]

Cancel the uplift request, it might cause regression on Window 7. It is not clear yet.

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)

Cancel the uplift request, it might cause regression on Window 7. It is not clear yet.

It seems like a bug of WebRender(Software D3D11). See Bug 1718497.

Comment 9

[Yaron]

Sotaro,

Thank you. I appreciate your work.