1717245 - Printing buttons with high-contrast-dark on windows but without printing backgrounds causes black-on-black text

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Str (on windows, with a dark high-contrast theme):

• Go to data:text/html,<button>ABC</button>.
• Print, make sure that "print backgrounds" is unchecked.

Expected:

• Readable text.

Actual: black on black, even with the patch for bug 1715783.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1717245 - Don't use system colors in the non-native theme if we're not painting backgrounds. r=mstange,morgan

(Like for printing with backgrounds disabled).

Otherwise layout darkens our foreground colors etc, and that causes contrast to
be poor.

Since the point of not painting backgrounds is saving ink, using the
regular colors seems fine.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcca441f1fc8
Don't use system colors in the non-native theme if we're not painting backgrounds. r=mstange

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/fcca441f1fc8