Closed Bug 1717276 Opened 3 years ago Closed 3 years ago

Allow to directly save a bookmark without having to confirm

Categories

(Firefox :: Bookmarks & History, enhancement)

Firefox 88
enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1691729

People

(Reporter: sblachmann, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Clicked the star to save bookmark.

Actual results:

Star is being filled, pretending the bookmark being stored.
But the bookmark is not being stored.

Lost MANY links I believed having bookmarked, because Firefox successfully fooled me into believing the bookmark had been added, due to the star being filled.

Expected results:

Just store the bookmark the way it was stored, before that annoying extra dialog was added, which pops up when clicking at the star.

So:
Best solution: Completely remove the annoying dialog.
Second-best solution: At least store the bookmark without demanding the user to click "Done" to have the bookmark actually stored.

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Bookmarks & History

The dialog displays a "Save" button. If you don't click it, then things don't get saved. This is pretty standard across applications.

Type: defect → enhancement
Summary: Bookmarks are not being stored → Allow to directly save a bookmark without having to confirm

But the bookmark IS stored unless you press Cancel or Escape. At least on Windows.

Well, I was used to just click the star.

The star becomes "filled", making me think the bookmark has been added.
(This worked fine, until some time ago this extra dialog was introduced, which appears when clicking the star.)

Then I either close the tab or just click elsewhere in the tab to continue reading.
The dialog disappears.
The star remains "filled", misleading the user in his belief that the bookmark has been stored.

So I think the code should be modified so that...
... either the bookmark is stored, even if the user ignores or clicks away the dialog, ...
... or the star should be "filled" only after the user does click on the "Done" button in the dialog that appears after clicking the star.

(Using Debian Linux and FreeBSD)

Are you sure the bookmark is not actually stored? Have you looked through all the bookmark folders in "Manage Bookmarks" and performed a search for one?

Flags: needinfo?(sblachmann)

Exploring the "Manage Bookmarks" window, I found that bookmarks were not only in the "Other bookmarks" folder (which gets displayed when I open the "Manage Bookmarks" window).
Many bookmarks I believed not to have been stored were in the "Bookmarks Toolbar" folder.
Using the bookmark search from the "Manage Bookmarks" window seems to work, unlike the more-accessible (books icon) -> (Bookmarks) -> (Search Bookmarks).

I haven't yet understood why most bookmarks are stored in the "Bookmarks Toolbar" folder, and some are being stored in the "Other bookmarks" folder.
Maybe this is connected with my impression that I did not find recently added bookmarks in "Recent Bookmarks" that I did not "confirm" by clicking "Done" in the menu which appears when clicking the star?

When I click the (books icon) -> (Bookmarks) -> (Search Bookmarks), and enter a search term there, it seems to search not only in the bookmarks, but also in the history.
This might be the reason why I got the impression that the bookmarks haven't been stored.
Because, there are displayed ten hits, apparently the most recent ones from history and bookmarks combined.
And if the most recent ten hits are from the history, actual bookmarks matching the search term are not being displayed at all.
Then these can only be found via the search box in the Bookmark Manager.

So I guess I need to find out how to configure (books icon) -> (Bookmarks) -> (Search Bookmarks) so that it does not search history, but only searches bookmarks.
Any idea how to do this?

Flags: needinfo?(sblachmann)

Setting this enhancement to NEW in order for it to gain more visibility.

Status: UNCONFIRMED → NEW
Ever confirmed: true

This reports seems to be related to the problem users have to find where bookmarks did go, and that problem may have been made worse by recent bookmark improvements that changed the default from Other to Toolbar, and reusing the last used folder.
I'm not sure I have a solution at hand to suggest, apart from the obvious description of how our bookmarks work and how to search. But that's not a great answer, it should be clear to a user where bookmarks go, by default.

There is some relationship with bug 1412263, but that is unlikely to help a new user figuring out where bookmarks go.
I think this is, more or less, similar to bug 1691729.

Note you can search bookmarks in multiple ways:

  1. there is a Search Bookmarks menuitem in the Bookmarks section of the main menu
  2. you can prepend your search with a * in the urlbar
  3. you can click on the urlbar to open it and pick the bookmark symbol at the bottom
  4. you can open the Library window (CTRL+SHIFT+O) and search
  5. you can open the Bookmarks sidebar (CTRL+B) and search
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.