1717348 - WebExtensions API regression in menus.onShown due to landing of Bug 1716022 (Return pages in the messages API as soon as they are ready)

Status: VERIFIED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

https://thunderbird.topicbox.com/groups/addons/Ta0dbca46355df626/webextensions-partially-broken-after-daily-update-from-15-06-2021-to-16-06-2021

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: (Outdated) AttachmentExtractor Continued 4.0a4 - Testcase MailExtension.xpi

Example MailExtension to reproduce the described bug

Be warned: Only en-US and de locales are working in this development version of this addon.

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

STR:

1. Install the provided MailExtensions (in development)
2. Open the error console
3. Right click in the thread pane

You will see the reported bug with the error console report, which is generated by the menus.onShown listener, when opening the context menu:

DataCloneError: The object could not be cloned. ExtensionParent.jsm:991

The MailExtension fails completely at this point.

The same MailExtension code works flawless in Thunderbird 90 Beta 2 and in Dailies before 16-06-2021.

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: AttachmentExtractor Continued 4.0a4 - Testcase MailExtension.xpi

Updated reproducer MailExtension with a little bit reduced code.

Comment 4

[John Bieling (:TbSync)]

Attachment: Bug 1717348 - Fix regression in menus.onShown. r=mkmelin

Comment 5

[John Bieling (:TbSync)]

Thanks for reporting this. Regression was introduced by Bug 1716022. Sorry for not seeing this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d6726f6a43e
Fix regression in menus.onShown. r=mkmelin

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Thanks, bug is fixed now.