Closed Bug 1717369 Opened 3 months ago Closed 3 months ago

Make line splitting a library utility function in cZ

Categories

(SeaMonkey :: Chat, enhancement)

Product:
SeaMonkey
Component:
Chat
Type:
enhancement

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.88
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.9)

Attachments

(1 file)

1717369-irc-linesplit-library-2539.patch
6.62 KB, patch
iann_bugzilla
: review+
iann_bugzilla
: approval-comm-release+
iann_bugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review

From Ambassador issue #80:
There's some code repetition between irc.js and static.js with regards to splitting long lines before sending them. This can be broken out into its own utility method in irc.js and then used in both places.
Patches cherry picked from Ambassador and tweaked:
https://github.com/Ascrod/ambassador/commit/83fa2052c0539bae922f3b69cfc24170842c3c44
https://github.com/Ascrod/ambassador/commit/29054341e6bd6996c42b862f0cc674d779db6301

[Triage Comment]
r/a=me

Attachment #9228023 - Flags: review+
Attachment #9228023 - Flags: approval-comm-release+
Attachment #9228023 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/711146ab4abf
Make line splitting a library utility function in cZ. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
status-seamonkey2.53: --- → affected
tracking-seamonkey2.53: --- → ?
Whiteboard: SM2.53.9
Target Milestone: --- → seamonkey 2.88
You need to log in before you can comment on or make changes to this bug.