1717432 - Re-enable the tests in browser/extensions/formautofill/test/browser/browser.ini that were disabled for bug 1600059

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Neil Deakin]

A number of these formautofill tests are disabled on Mac.

This issue on Mac which affects a number of tests is that the docshell or document is not yet initialized in some manner (haven't fully investigated), so the formfill code cannot get the windowtype to use (at https://searchfox.org/mozilla-central/rev/716d7cd80b3dcd81c005ad13b51d3e6a85bd7e73/xpfe/appshell/nsAppShellWindowEnumerator.cpp#29 )

Comment 1

[Tim Giles [:tgiles]]

Resolving Bug 1717603 may fix these tests as well.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1717432 - Re-enable tests that are disabled in Bug 1632098 r=sgalich,tgiles

The issue that causes those tests fail should be fixed in Bug 1717603

However, There are still two tests have this comment "perma-fail see Bug 1600059"

• browser_privacyPreferences.js (Disabled in Bug 1745248)
• browser_editCreditCardDialog.js (Disabled in Bug 1664620)

The reason we don't enable the two tests is because those tests were disable in
different bugs and it seems there are other issues causes we disable the tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bc3f70298aa
Re-enable tests that are disabled in Bug 1632098 r=sgalich,tgiles

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures on browser_anti_clickjacking.js . CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/c9e919bb40ded7fd42119177558fc7243cdc374e

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C11%2Cwebrender%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwith%2Cfission%2Cenabled%2Ctest-macosx1100-64-shippable-qr%2Fopt-mochitest-browser-chrome-spi-nw-fis-e10s%2Cbc5&revision=8bc3f70298aa9b24fff89d6c35b52b8d99078283

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=371873460&repo=autoland&lineNumber=6276

Failure message : TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/creditCard/browser_anti_clickjacking.js | Test timed out

Comment 5

[Dimi Lee [:dimi]]

The browser_anti_clickjacking testcase heavily depends on timing, I'll continue to disable the test for now so we can enable the other tests first.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b61729e61c63
Re-enable tests that are disabled in Bug 1632098 r=sgalich,tgiles

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b61729e61c63