1717445 - Permanent Btime failures when Gecko 91 merges to Beta on 2021-07-12

Status: VERIFIED FIXED

(Testing :: Raptor, defect, P1)

Description

[Dorel Luca [:dluca]]

Central as beta simulation:
https://treeherder.mozilla.org/jobs?repo=try&revision=ab41aef0633fb53dbc3ceaebb3ef9663c65c833e&searchStr=browsertime

Log:
https://treeherder.mozilla.org/logviewer?job_id=343373568&repo=try&lineNumber=994

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Last successful run was on June 8th. Bug 1712958 is responsible for not reliable scheduling it.

I will manually add a browsertime task to the central-as-beta simulations between this last good one and today's to identify when it started.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Affected pushlog. Greg, this looks like a regression from bug 1708760.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

If we need to fix this quickly, we could remove the --conditioned-profile=settled from the command line used to run the tests. This would revert to using a fresh profile and settling the browser rather than conditioning a profile first. It's unlikely we'll be able to investigate this in the next couple of weeks.

Comment 4

[Greg Mierzwinski [:sparky]]

:aryx, is there a way that I could run this central-as-beta simulation locally? I think there's something in condprof that's branch-specific.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Documentation how to run these simulations can be found here. The shippable builds are different and complicated to reproduce locally - please try 'opt' instead of shippable if there are issues.

Comment 6

[Greg Mierzwinski [:sparky]]

So I managed to reproduce the failure locally. Looking at the geckodriver logs and I'm seeing this error:

FATAL ERROR: Non-local network connections are disabled and a connection attempt to location.services.mozilla.com (54.186.138.163) was made.
You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.

FWIW, here's the method I used to reproduce it:

1. Update mozilla-central to update to the parent revision that central-as-beta simulation is running on.
2. Import the central-as-beta simulation patch from the try run.
3. Download the binary being used in the failing tests.
4. Run the command from the test that is failing with --binary pointing to the downloaded Firefox binary.

Patch incoming.

Comment 7

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1717445 - Allow non-local connections when running condprof. r?#perftest

This patch enables non-local connections when we are running condprof to obtain a conditioned profile. The only reason these connections are being disabled to begin with is because of the web-extension we use. This fixes an issue with using the condprofs in release builds such as beta.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da8e89133218
Allow non-local connections when running condprof. r=perftest-reviewers,AlexandruIonescu

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/da8e89133218

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation.