1717488 - [wpt-sync] Sync PR 29447 - Run flow thread style change DCHECK in fewer cases.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 29447 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29447
Details from upstream follow.

b'Morten Stenshorne <[e-mail]>' wrote:

Run flow thread style change DCHECK in fewer cases.

Only DCHECK when necessary, i.e. when we might want to toggle spanner
descendants.

There's a DCHECK that asserts that a call to
FlowThreadDescendantStyleWillChange() on a descendant is followed by a
call to FlowThreadDescendantStyleDidChange() on the same descendant, but
this doesn't happen if the object is considered to be part of the flow
thread only before or after the style change. This happens when
column-span:all is toggled.

Bug: 1219401
Change-Id: Ib5db2625aa13723d897420405d00671aba2e3a46
Reviewed-on: https://chromium-review.googlesource.com/2975457
WPT-Export-Revision: 29979f035c5e123fe043888e44b8fffb06239d16

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d5ebcd7afb34d706577ad109a788161d599bf02

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a4ac9cae94a
[wpt PR 29447] - Run flow thread style change DCHECK in fewer cases., a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8a4ac9cae94a